linux-kernel - Re: [PATCH V2 6/8] pert tests: Update metric-value for perf stat JSON output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fVooOBWHWa8=73uS+eS1kW-qF5cp=WRV5O83SRE=oC6wQ@mail.gmail.com>
Date:   Wed, 14 Jun 2023 22:58:11 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     kan.liang@...ux.intel.com
Cc:     acme@...nel.org, mingo@...hat.com, peterz@...radead.org,
        namhyung@...nel.org, jolsa@...nel.org, adrian.hunter@...el.com,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, eranian@...gle.com, ahmad.yasin@...el.com
Subject: Re: [PATCH V2 6/8] pert tests: Update metric-value for perf stat JSON output

On Wed, Jun 14, 2023 at 5:18 PM <kan.liang@...ux.intel.com> wrote:
>
> From: Kan Liang <kan.liang@...ux.intel.com>
>
> There may be multiplexing triggered, e.g., e-core of ADL.
>
> Signed-off-by: Kan Liang <kan.liang@...ux.intel.com>

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/tests/shell/lib/perf_json_output_lint.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/tests/shell/lib/perf_json_output_lint.py b/tools/perf/tests/shell/lib/perf_json_output_lint.py
> index 5e9bd68c83fe..ea55d5ea1ced 100644
> --- a/tools/perf/tests/shell/lib/perf_json_output_lint.py
> +++ b/tools/perf/tests/shell/lib/perf_json_output_lint.py
> @@ -66,10 +66,10 @@ def check_json_output(expected_items):
>    for item in json.loads(input):
>      if expected_items != -1:
>        count = len(item)
> -      if count != expected_items and count >= 1 and count <= 4 and 'metric-value' in item:
> +      if count != expected_items and count >= 1 and count <= 6 and 'metric-value' in item:
>          # Events that generate >1 metric may have isolated metric
> -        # values and possibly other prefixes like interval, core and
> -        # aggregate-number.
> +        # values and possibly other prefixes like interval, core,
> +        # aggregate-number, or event-runtime/pcnt-running from multiplexing.
>          pass
>        elif count != expected_items and count >= 1 and count <= 5 and 'metricgroup' in item:
>          pass
> --
> 2.35.1
>