[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ea609d62-0b2e-7b1d-112e-01fafa9d0311@microchip.com>
Date: Thu, 15 Jun 2023 05:59:15 +0000
From: <Manikandan.M@...rochip.com>
To: <conor@...nel.org>
CC: <alexandre.belloni@...tlin.com>, <devicetree@...r.kernel.org>,
<dri-devel@...ts.freedesktop.org>, <Nicolas.Ferre@...rochip.com>,
<Hari.PrasathGE@...rochip.com>,
<krzysztof.kozlowski+dt@...aro.org>,
<Varshini.Rajendran@...rochip.com>, <sam@...nborg.org>,
<Balamanikandan.Gunasundar@...rochip.com>, <lee@...nel.org>,
<Dharma.B@...rochip.com>, <Nayabbasha.Sayed@...rochip.com>,
<conor+dt@...nel.org>, <robh+dt@...nel.org>,
<Durai.ManickamKR@...rochip.com>,
<linux-arm-kernel@...ts.infradead.org>,
<Balakrishnan.S@...rochip.com>, <bbrezillon@...nel.org>,
<linux-kernel@...r.kernel.org>, <Claudiu.Beznea@...rochip.com>
Subject: Re: [PATCH 6/9] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD
driver
On 13/06/23 23:47, Conor Dooley wrote:
> On Tue, Jun 13, 2023 at 12:34:23PM +0530, Manikandan Muralidharan wrote:
>> - XLCDC in SAM9X7 has different sets of registers and additional
>> configuration bits when compared to previous HLCDC IP. Read/write
>> operation on the controller registers is now separated using the
>> XLCDC status flag.
>> - HEO scaling, window resampling, Alpha blending, YUV-to-RGB
>> conversion in XLCDC is derived and handled using additional
>> configuration bits and registers.
>> - Writing one to the Enable fields of each layer in LCD_ATTRE
>> is required to reflect the values set in Configuration, FBA, Enable
>> registers of each layer
>>
>> Signed-off-by: Manikandan Muralidharan <manikandan.m@...rochip.com>
>> [Hari.PrasathGE@...rochip.com: update the attribute field for each layer]
>> Signed-off-by: Hari Prasath Gujulan Elango <Hari.PrasathGE@...rochip.com>
>> [durai.manickamkr@...rochip.com: implement status flag to seprate register update]
>
> These things inside [] look suspiciously like they should be
> co-developed-bys...
Ok, I will update as suggested.
>
--
Thanks and Regards,
Manikandan M.
Powered by blists - more mailing lists