linux-kernel - Re: [PATCH v2 4/5] arm64: dts: ti: add verdin am62 dahlia

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZIqwA3uC8nz2s9IN@francesco-nb.int.toradex.com>
Date:   Thu, 15 Jun 2023 08:30:27 +0200
From:   Francesco Dolcini <francesco@...cini.it>
To:     Vignesh Raghavendra <vigneshr@...com>
Cc:     Francesco Dolcini <francesco@...cini.it>,
        Nishanth Menon <nm@...com>,
        Francesco Dolcini <francesco.dolcini@...adex.com>,
        Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/5] arm64: dts: ti: add verdin am62 dahlia

On Thu, Jun 15, 2023 at 11:52:22AM +0530, Vignesh Raghavendra wrote:
> 
> 
> On 01/06/23 18:43, Francesco Dolcini wrote:
> 
> [...]
> 
> > +/* Verdin I2C_1 */
> > +&main_i2c1 {
> > +	status = "okay";
> > +
> > +	/* Audio Codec */
> > +	wm8904_1a: audio-codec@1a {
> > +		compatible = "wlf,wm8904";
> 
> This node doesn't have YAML bindings :(

Correct. I do not see a problem with that for this specific patch.

> > +		AVDD-supply = <&reg_1v8_sw>;
> > +		CPVDD-supply = <&reg_1v8_sw>;
> > +		DBVDD-supply = <&reg_1v8_sw>;
> > +		DCVDD-supply = <&reg_1v8_sw>;
> > +		MICVDD-supply = <&reg_1v8_sw>;
> 
> I dont see these properties in .txt bindings either.

Yes, the .txt file is not correct. See here for more details
https://lore.kernel.org/all/20230405200341.4911-1-danascape@gmail.com/

With that said they are required

$ grep -A5 wm8904_supply_names sound/soc/codecs/wm8904.c
static const char *wm8904_supply_names[WM8904_NUM_SUPPLIES] = {
	"DCVDD",
	"DBVDD",
	"AVDD",
	"CPVDD",
	"MICVDD",
--
		wm8904->supplies[i].supply = wm8904_supply_names[i];

	ret = devm_regulator_bulk_get(&i2c->dev, ARRAY_SIZE(wm8904->supplies),
				      wm8904->supplies);
	if (ret != 0) {
		dev_err(&i2c->dev, "Failed to request supplies: %d\n", ret);


Francesco