linux-kernel - Re: [PATCH v2 3/5] arm64: dts: ti: add verdin am62

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZIq02whTEce8C1P8@francesco-nb.int.toradex.com>
Date:   Thu, 15 Jun 2023 08:51:07 +0200
From:   Francesco Dolcini <francesco@...cini.it>
To:     Vignesh Raghavendra <vigneshr@...com>
Cc:     Francesco Dolcini <francesco@...cini.it>,
        Nishanth Menon <nm@...com>,
        Francesco Dolcini <francesco.dolcini@...adex.com>,
        Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/5] arm64: dts: ti: add verdin am62

On Thu, Jun 15, 2023 at 11:38:00AM +0530, Vignesh Raghavendra wrote:
> 
> 
> On 01/06/23 18:43, Francesco Dolcini wrote:
> 
> [...]
> 
> > +/* Verdin I2C_1 */
> > +&main_i2c1 {
> > +	status = "okay";
> > +
> > +	/* Audio Codec */
> > +	nau8822_1a: audio-codec@1a {
> > +		compatible = "nuvoton,nau8822";
> > +		reg = <0x1a>;
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_i2s1_mclk>; /* Configure AUDIO_EXT_REFCLK1 pin as output */
> > +		#sound-dai-cells = <0>;
> > +
> > +		/* POSTDIV4_16FF_MAIN_2_HSDIVOUT8_CLK -> AUDIO_EXT_REFCLK1 */
> > +		assigned-clocks = <&k3_clks 157 10>;
> > +		assigned-clock-parents = <&k3_clks 157 18>;
> > +		assigned-clock-rates = <25000000>; /* for 48KHz ± 1.7% */
> > +	};
> > +
> 
> Oops, this node fails dtbs_check
> 
> make ARCH=arm64 CROSS_COMPILE=$V8_CROSS CHECK_DTBS=y ti/k3-am625-verdin-nonwifi-dev.dtb
> 
> /work/linux/arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dev.dtb: audio-codec@1a: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
> 	From schema: /home/a0132425/workspace/k3-next/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
> /work/linux/arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dev.dtb: audio-codec@1a: 'anyOf' conditional failed, one must be fixed:
> 	'clocks' is a required property
> 	'#clock-cells' is a required property
> 	From schema: /work/.local/lib/python3.10/site-packages/dtschema/schemas/clock/clock.yaml

This properties are needed here, it will not work without.

Not the expert on audio codec and sound cards DT binding, but to me this is
just the yaml not being correct.

Francesco