linux-kernel - Re: usb: typec: tcpm: fix cc role at port reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4bc4e7e-b9d4-432b-2157-f5b30c160a3a@rock-chips.com>
Date:   Fri, 16 Jun 2023 11:03:14 +0800
From:   Frank Wang <frank.wang@...k-chips.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     heikki.krogerus@...ux.intel.com, gregkh@...uxfoundation.org,
        sebastian.reichel@...labora.com, heiko@...ech.de,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, huangtao@...k-chips.com,
        william.wu@...k-chips.com, jianwei.zheng@...k-chips.com,
        yubing.zhang@...k-chips.com, wmc@...k-chips.com
Subject: Re: usb: typec: tcpm: fix cc role at port reset

Hi Guenter,

On 2023/6/16 10:27, Guenter Roeck wrote:
> On 6/15/23 19:20, Frank Wang wrote:
>> In the current implementation, the tcpm set CC1/CC2 role to open when
>> it do port reset would cause the VBUS removed by the Type-C partner.
>>
>> This sets CC1/CC2 according to the default state of port to fix it.
>>
>> Comments are suggested by Guenter Roeck.
>>
>
> I have no idea (recollection) of what I suggested here :-(

Aha, this is also an old patch I have sent before, you suggested that 
the cc role should require some tweaking based on the port type or 
default state, do you remember it now?

Anyway, Can you help to review this patch again?


BR.
Frank

>
> Guenter
>
>> Signed-off-by: Frank Wang <frank.wang@...k-chips.com>
>> ---
>>   drivers/usb/typec/tcpm/tcpm.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/typec/tcpm/tcpm.c 
>> b/drivers/usb/typec/tcpm/tcpm.c
>> index 3c6b0c8e2d3ae..9f6aaa3e70ca8 100644
>> --- a/drivers/usb/typec/tcpm/tcpm.c
>> +++ b/drivers/usb/typec/tcpm/tcpm.c
>> @@ -4885,7 +4885,8 @@ static void run_state_machine(struct tcpm_port 
>> *port)
>>           break;
>>       case PORT_RESET:
>>           tcpm_reset_port(port);
>> -        tcpm_set_cc(port, TYPEC_CC_OPEN);
>> +        tcpm_set_cc(port, tcpm_default_state(port) == SNK_UNATTACHED ?
>> +                TYPEC_CC_RD : tcpm_rp_cc(port));
>>           tcpm_set_state(port, PORT_RESET_WAIT_OFF,
>>                      PD_T_ERROR_RECOVERY);
>>           break;
>