linux-kernel - Re: usb: typec: tcpm: fix cc role at port reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023061643-uplifting-sequester-0152@gregkh>
Date:   Fri, 16 Jun 2023 08:06:00 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Frank Wang <frank.wang@...k-chips.com>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        heikki.krogerus@...ux.intel.com, sebastian.reichel@...labora.com,
        heiko@...ech.de, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        huangtao@...k-chips.com, william.wu@...k-chips.com,
        jianwei.zheng@...k-chips.com, yubing.zhang@...k-chips.com,
        wmc@...k-chips.com
Subject: Re: usb: typec: tcpm: fix cc role at port reset

On Fri, Jun 16, 2023 at 11:03:14AM +0800, Frank Wang wrote:
> Hi Guenter,
> 
> On 2023/6/16 10:27, Guenter Roeck wrote:
> > On 6/15/23 19:20, Frank Wang wrote:
> > > In the current implementation, the tcpm set CC1/CC2 role to open when
> > > it do port reset would cause the VBUS removed by the Type-C partner.
> > > 
> > > This sets CC1/CC2 according to the default state of port to fix it.
> > > 
> > > Comments are suggested by Guenter Roeck.
> > > 
> > 
> > I have no idea (recollection) of what I suggested here :-(
> 
> Aha, this is also an old patch I have sent before, you suggested that the cc
> role should require some tweaking based on the port type or default state,
> do you remember it now?

Please version the patch, and provide the change information as
documented.

thanks,

greg k-h