linux-kernel - Re: [PATCH v2 1/1] scripts/rust_is_available: Fix clang version check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72ng7Ss=s36EXZyG+nx+DRd=XNM+ZU6kPmY00LKaXsjjSw@mail.gmail.com>
Date:   Fri, 16 Jun 2023 02:30:49 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     "Ethan D. Twardy" <ethan.twardy@...il.com>
Cc:     Miguel Ojeda <ojeda@...nel.org>,
        Alex Gaynor <alex.gaynor@...il.com>,
        Wedson Almeida Filho <wedsonaf@...il.com>,
        Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        Benno Lossin <benno.lossin@...ton.me>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>, Tiago Lam <tiagolam@...il.com>,
        Kees Cook <keescook@...omium.org>, Finn Behrens <me@...enk.de>,
        "open list:RUST" <rust-for-linux@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:CLANG/LLVM BUILD SUPPORT" <llvm@...ts.linux.dev>
Subject: Re: [PATCH v2 1/1] scripts/rust_is_available: Fix clang version check

On Sun, May 28, 2023 at 3:21 PM Ethan D. Twardy <ethan.twardy@...il.com> wrote:
>
> During out-of-tree builds where the path to the kernel source tree
> contains a version string, scripts/rust_is_available.sh incorrectly
> identified the version string of libclang to be the version string in
> the kernel sources path, resulting in CONFIG_RUST_IS_AVAILABLE
> erroneously set to 'n'.
>
> This issue was previously affecting builds on distributions, such as
> Gentoo Linux, where the kernel source tree is under version control,
> and placed under a path containing the current kernel version string
> in /usr/src.
>
> The fix is to take special care to match only the version string
> following the string 'clang version' in the output.
>
> To reproduce:
>
>   $ cd ~/build && make -C ~/linux-6.2.0 O=$PWD LLVM=1 rustavailable
>   [...]
>   *** libclang (used by the Rust bindings generator 'bindgen') is too old.
>   ***   Your version:    6.2.0
>   ***   Minimum version: 11.0.0
>   [...]
>
> Fixes: 78521f3399ab ("scripts: add `rust_is_available.sh`")
> Signed-off-by: Ethan D. Twardy <ethan.twardy@...il.com>

Thanks a lot for this patch! This was previously reported and should
be fixed in this patch series (I added you as a reporter in v2):

    https://lore.kernel.org/rust-for-linux/20230616001631.463536-1-ojeda@kernel.org/

If you could please test the series, to make sure it solves your
issue, it would be great!

Cheers,
Miguel