linux-kernel - Re: [PATCH v5 1/2] axis-fifo: use devm_kasprintf() for allocating formatted strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023061750-blog-curse-c1a3@gregkh>
Date:   Sat, 17 Jun 2023 16:00:02 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Prathu Baronia <prathubaronia2011@...il.com>
Cc:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Khadija Kamran <kamrankhadijadj@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, dan.carpenter@...aro.org,
        error27@...il.com, lkp@...el.com, oe-kbuild-all@...ts.linux.dev,
        oe-kbuild@...ts.linux.dev
Subject: Re: [PATCH v5 1/2] axis-fifo: use devm_kasprintf() for allocating
 formatted strings

On Fri, Jun 16, 2023 at 08:55:59PM +0530, Prathu Baronia wrote:
> In various places, string buffers of a fixed size are allocated, and
> filled using snprintf() with the same fixed size, which is error-prone.
> 
> Replace this by calling devm_kasprintf() instead, which always uses the
> appropriate size. Allocate the device name with a unique identifier
> instead of a kernel address.

You are doing two different things here, one is changing the allocation
way, and the other is the name.  If one of those things turns out to
break something, we have to revert this whole thing.

So please make this two different changes, one to change to use
devm_kasprintf() and the second to change the naming scheme, ESPECIALLY
as you do not mention the name change in the subject line.  And that's
going to be a user-visible change, so you need to make that VERY
obvious.

thanks,

greg k-h