linux-kernel - Re: [PATCH v5 1/2] axis-fifo: use devm_kasprintf() for allocating formatted strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZI/5H+GZU6/2osGT@redkillpc>
Date:   Mon, 19 Jun 2023 12:13:43 +0530
From:   Prathu Baronia <prathubaronia2011@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Khadija Kamran <kamrankhadijadj@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, dan.carpenter@...aro.org,
        error27@...il.com, lkp@...el.com, oe-kbuild-all@...ts.linux.dev,
        oe-kbuild@...ts.linux.dev
Subject: Re: [PATCH v5 1/2] axis-fifo: use devm_kasprintf() for allocating
 formatted strings

On Sat, Jun 17, 2023 at 04:00:02PM +0200, Greg Kroah-Hartman wrote:
> 
> You are doing two different things here, one is changing the allocation
> way, and the other is the name.  If one of those things turns out to
> break something, we have to revert this whole thing.
> 
> So please make this two different changes, one to change to use
> devm_kasprintf() and the second to change the naming scheme, ESPECIALLY
> as you do not mention the name change in the subject line.  And that's
> going to be a user-visible change, so you need to make that VERY
> obvious.
Makes sense greg, will do in v6.

Prathu