linux-kernel - Re: [PATCH v3 2/9] clk: ralink: add clock and reset driver for MTMIPS SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 17 Jun 2023 21:11:46 +0200
From:   Sergio Paracuellos <sergio.paracuellos@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Shiji Yang <yangshiji66@...look.com>, arinc.unal@...nc9.com,
        devicetree@...r.kernel.org, john@...ozen.org,
        krzysztof.kozlowski+dt@...aro.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
        matthias.bgg@...il.com, mturquette@...libre.com,
        p.zabel@...gutronix.de, robh+dt@...nel.org, sboyd@...nel.org,
        tsbogend@...ha.franken.de
Subject: Re: [PATCH v3 2/9] clk: ralink: add clock and reset driver for MTMIPS SoCs

On Sat, Jun 17, 2023 at 7:20 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 17/06/2023 17:37, Sergio Paracuellos wrote:
> >>> The case of
> >>> searching for compatible is a mess since as you can see in the
> >>> bindings there are tons of compatibles to search for, then (this code
> >>> is common to all ralink platforms).
> >>
> >> Compatible is one of the ways using ABI.
> >
> > Ok so it is also a broken approach, then.
>
> What is exactly broken approach? Fetching by compatibles? Somehow many
> other platforms do not have problem with that, even for multiple
> compatibles. Why yours is special?

I guess it is not special but I cannot figure out the way of getting
this clock using compatibles...

>
> Anyway, it is not a correct way to get clocks frequency. There is CCF
> for this, although maybe Ralink does not support it?

This means to use clk_get() if I understand properly but it does not
work at all for ralink...

>
> Best regards,
> Krzysztof
>

Thanks,
    Sergio Paracuellos