linux-kernel - Re: [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c70cb3cb326439a5868beb54d720538923f653d1.camel@crapouillou.net>
Date:   Sat, 17 Jun 2023 21:13:37 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     Sui Jingfeng <suijingfeng@...ngson.cn>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     linux-mips@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO

Hi,

Le mercredi 07 juin 2023 à 19:06 +0800, Sui Jingfeng a écrit :
> Otherwise its failed to pass basic compile test on platform without
> REGMAP_MMIO selected by defconfig
> 
> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
> 
>   SYNC    include/config/auto.conf.cmd
>   Checking missing-syscalls for N32
>   CALL    scripts/checksyscalls.sh
>   Checking missing-syscalls for O32
>   CALL    scripts/checksyscalls.sh
>   CALL    scripts/checksyscalls.sh
>   MODPOST Module.symvers
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
> make: *** [Makefile:1978: modpost] Error 2
> 
> V2: Order alphabetically
> 
> Signed-off-by: Sui Jingfeng <suijingfeng@...ngson.cn>

The patch looks good to me. But I need an ACK from someone else to
apply to drm-misc-next.

Cheers,
-Paul

> ---
>  drivers/gpu/drm/ingenic/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/ingenic/Kconfig
> b/drivers/gpu/drm/ingenic/Kconfig
> index a53f475d33df..b440e0cdc057 100644
> --- a/drivers/gpu/drm/ingenic/Kconfig
> +++ b/drivers/gpu/drm/ingenic/Kconfig
> @@ -9,6 +9,8 @@ config DRM_INGENIC
>         select DRM_PANEL_BRIDGE
>         select DRM_KMS_HELPER
>         select DRM_GEM_DMA_HELPER
> +       select REGMAP
> +       select REGMAP_MMIO
>         select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE
>         help
>           Choose this option for DRM support for the Ingenic SoCs.