linux-kernel - Re: [PATCH 4/6] dt-bindings: serial: amlogic, meson-uart: support T7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJX_Q+2ND=GJEEXdLLpEWoecN5gtZm-1i92pAgi+eQocSRUVqw@mail.gmail.com>
Date:   Sun, 18 Jun 2023 18:37:40 +0100
From:   Lucas Tanure <tanure@...ux.com>
To:     Conor Dooley <conor@...nel.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Jerome Brunet <jbrunet@...libre.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Kevin Hilman <khilman@...libre.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nick <nick@...das.com>, Artem <art@...das.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-amlogic@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 4/6] dt-bindings: serial: amlogic, meson-uart: support T7

On Thu, Jun 15, 2023 at 10:25 PM Conor Dooley <conor@...nel.org> wrote:
>
> On Thu, Jun 15, 2023 at 07:29:36PM +0100, Lucas Tanure wrote:
> > Add serial bindings support menson T7 SoC family.
> >
> > Signed-off-by: Lucas Tanure <tanure@...ux.com>
> > ---
> >  Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> > index 01ec45b3b406..01b01f8840ea 100644
> > --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> > @@ -46,6 +46,7 @@ properties:
> >            - amlogic,meson8b-uart
> >            - amlogic,meson-gx-uart
> >            - amlogic,meson-s4-uart
> > +          - amlogic,meson-t7-uart
>
> | diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> | index 2501db5a7aaf..0208f9a6ba7e 100644
> | --- a/drivers/tty/serial/meson_uart.c
> | +++ b/drivers/tty/serial/meson_uart.c
> | @@ -796,6 +796,10 @@ static const struct of_device_id meson_uart_dt_match[] = {
> |                 .compatible = "amlogic,meson-s4-uart",
> |                 .data = (void *)&meson_g12a_uart_data,
> |         },
> | +       {
> | +               .compatible = "amlogic,meson-t7-uart",
> | +               .data = (void *)&meson_g12a_uart_data,
> | +       },
> |         { /* sentinel */ },
> |  };
> |  MODULE_DEVICE_TABLE(of, meson_uart_dt_match);
>
> You're adding another element to this enum, but the driver change
> implies compatibility with the s4 uart. Should you not set this up with
> fallback compatibles?

I will drop this patch and use the s4 and g12a compatible strings.

>
> Cheers,
> Conor.
>
> >        - description: Everything-Else power domain UART controller on G12A SoCs
> >          items:
> >            - const: amlogic,meson-g12a-uart
> > --
> > 2.41.0
> >