[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8dba5075-3e30-3edd-e66b-199cffefe708@starfivetech.com>
Date: Mon, 19 Jun 2023 15:27:43 +0800
From: William Qiu <william.qiu@...rfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
<devicetree@...r.kernel.org>, <linux-spi@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-riscv@...ts.infradead.org>
CC: Mark Brown <broonie@...nel.org>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Emil Renner Berthing <kernel@...il.dk>,
Ziv Xu <ziv.xu@...rfivetech.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: qspi: cdns,qspi-nor: Add clocks for
StarFive JH7110 SoC
On 2023/6/6 20:43, Krzysztof Kozlowski wrote:
> On 02/06/2023 10:49, William Qiu wrote:
>> The QSPI controller needs three clock items to work properly on StarFive
>> JH7110 SoC, so there is need to change the maxItems's value to 3. Other
>> platforms do not have this constraint.
>>
>> Signed-off-by: William Qiu <william.qiu@...rfivetech.com>
>> Reviewed-by: Hal Feng <hal.feng@...rfivetech.com>
>
>
>
>>
>> @@ -69,9 +81,6 @@ properties:
>> interrupts:
>> maxItems: 1
>>
>> - clocks:
>> - maxItems: 1
>
> Properties should be defined in top-level properties. Don't remove them
> from here.
>
> Best regards,
> Krzysztof
>
Hi Krzysztof,
Sorry for the late reply. I'll fix it in next version.
Best regards,
William
Powered by blists - more mailing lists