linux-kernel - Re: [PATCH v2 0/6] Enhance AMD SMN Error Checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eddd118b-a10b-7208-7e96-df909d038233@amd.com>
Date:   Sun, 18 Jun 2023 21:42:18 -0500
From:   Mario Limonciello <mario.limonciello@....com>
To:     Yazen Ghannam <yazen.ghannam@....com>, x86@...nel.org
Cc:     linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        markgross@...nel.org, hdegoede@...hat.com,
        Shyam-sundar.S-k@....com, linux-edac@...r.kernel.org,
        clemens@...isch.de, jdelvare@...e.com, linux@...ck-us.net,
        linux-hwmon@...r.kernel.org, babu.moger@....com
Subject: Re: [PATCH v2 0/6] Enhance AMD SMN Error Checking

On 6/15/23 11:03, Yazen Ghannam wrote:
> Hi all,
> 
> This set implements more robust error checking for AMD System Management
> Network (SMN) accesses.
> 
> This set is a follow up to this discussion:
> https://lore.kernel.org/lkml/20230403164244.471141-1-yazen.ghannam@amd.com/
> 
> Patches 1-3:
> 	- Pre-patches in AMD64 EDAC and K10Temp modules.
> 	- Required in order to avoid build warnings with the
> 	  introduction of the __must_check attribute in patch 4.
> Patch 4:
> 	- Introduces __must_check attribute for SMN access functions.
> 	- Handles "PCI Error Response" behavior for SMN reads.
> Patches 5-6:
> 	- Optional cleanup patches in k10temp.
> 	- Not required for the SMN access issue, but I thought they may
> 	  be good to do.
> 

Each of the patches in the series looks good to me.
Reviewed-by: Mario Limonciello <mario.limonciello@....com>

> I've included x86 platform driver folks for awareness, since there are
> some AMD SMN users there.

These uses seem to be handled fine by the existing error checking to me.
There is also a consumer of amd_smn_read/amd_smn_write in 
arch/x86/pci/fixup.c that I think looks fine still.

> 
> Thanks,
> Yazen
> 
> Link:
> https://lore.kernel.org/r/20230516202430.4157216-1-yazen.ghannam@amd.com
> 
> v1->v2:
> * Rebase on tip/master.
> * Address comments from Guenter.
> 
> Yazen Ghannam (6):
>    EDAC/amd64: Remove unused register accesses
>    EDAC/amd64: Check return value of amd_smn_read()
>    hwmon: (k10temp) Check return value of amd_smn_read()
>    x86/amd_nb: Enhance SMN access error checking
>    hwmon: (k10temp) Define helper function to read CCD temp
>    hwmon: (k10temp) Reduce k10temp_get_ccd_support() parameters
> 
>   arch/x86/include/asm/amd_nb.h |  4 +--
>   arch/x86/kernel/amd_nb.c      | 46 ++++++++++++++++++++----
>   drivers/edac/amd64_edac.c     | 68 +++++++++++++++++++----------------
>   drivers/edac/amd64_edac.h     |  4 ---
>   drivers/hwmon/k10temp.c       | 57 +++++++++++++++++++----------
>   5 files changed, 119 insertions(+), 60 deletions(-)
>