[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ad43c064-0593-a30a-84eb-33618d0c868e@linaro.org>
Date: Mon, 19 Jun 2023 15:12:09 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
cros-qcom-dts-watchers@...omium.org,
Nikita Travkin <nikita@...n.ru>,
Stephan Gerhold <stephan@...hold.net>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/15] arm64: dts: qcom: apq8016-sbc: drop label from I2C
and SPI
On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> I2C and SPI controller bindings do not allow label property:
>
> apq8016-sbc.dtb: spi@...7000: Unevaluated properties are not allowed ('label' was unexpected)
> apq8016-sbc.dtb: i2c@...6000: Unevaluated properties are not allowed ('label' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>
Konrad
> arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> index f3d65a606194..e0993e32ee38 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> @@ -172,15 +172,13 @@ led@6 {
> };
>
> &blsp_i2c2 {
> - /* On Low speed expansion */
> + /* On Low speed expansion: LS-I2C0 */
> status = "okay";
> - label = "LS-I2C0";
> };
>
> &blsp_i2c4 {
> - /* On High speed expansion */
> + /* On High speed expansion: HS-I2C2 */
> status = "okay";
> - label = "HS-I2C2";
>
> adv_bridge: bridge@39 {
> status = "okay";
> @@ -228,21 +226,18 @@ adv7533_out: endpoint {
> };
>
> &blsp_i2c6 {
> - /* On Low speed expansion */
> + /* On Low speed expansion: LS-I2C1 */
> status = "okay";
> - label = "LS-I2C1";
> };
>
> &blsp_spi3 {
> - /* On High speed expansion */
> + /* On High speed expansion: HS-SPI1 */
> status = "okay";
> - label = "HS-SPI1";
> };
>
> &blsp_spi5 {
> - /* On Low speed expansion */
> + /* On Low speed expansion: LS-SPI0 */
> status = "okay";
> - label = "LS-SPI0";
> };
>
> &blsp_uart1 {
Powered by blists - more mailing lists