linux-kernel - Re: [PATCH 04/15] arm64: dts: qcom: apq8096-db820c: drop label from I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48db4706-de69-04ff-2733-ab05ecfaa9df@linaro.org>
Date:   Mon, 19 Jun 2023 15:12:19 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        cros-qcom-dts-watchers@...omium.org,
        Nikita Travkin <nikita@...n.ru>,
        Stephan Gerhold <stephan@...hold.net>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/15] arm64: dts: qcom: apq8096-db820c: drop label from
 I2C

On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> I2C controller bindings do not allow label property:
> 
>   apq8096-db820c.dtb: i2c@...7000: Unevaluated properties are not allowed ('label' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>  arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> index 537547b97459..002cf5806d83 100644
> --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> @@ -138,8 +138,7 @@ wlan_en: wlan-en-1-8v {
>  };
>  
>  &blsp1_i2c3 {
> -	/* On Low speed expansion */
> -	label = "LS-I2C0";
> +	/* On Low speed expansion: LS-I2C0 */
>  	status = "okay";
>  };
>  
> @@ -168,14 +167,12 @@ &adsp_pil {
>  };
>  
>  &blsp2_i2c1 {
> -	/* On High speed expansion */
> -	label = "HS-I2C2";
> +	/* On High speed expansion: HS-I2C2 */
>  	status = "okay";
>  };
>  
>  &blsp2_i2c1 {
> -	/* On Low speed expansion */
> -	label = "LS-I2C1";
> +	/* On Low speed expansion: LS-I2C1 */
>  	status = "okay";
>  };
>