linux-kernel - Re: [PATCH 09/15] arm64: dts: qcom: sc7280-crd: add dummy Bluetooth VDDIO supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29f6fb78-c122-2b71-61b8-2dc9aa27ad1d@linaro.org>
Date:   Mon, 19 Jun 2023 15:14:30 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        cros-qcom-dts-watchers@...omium.org,
        Nikita Travkin <nikita@...n.ru>,
        Stephan Gerhold <stephan@...hold.net>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH 09/15] arm64: dts: qcom: sc7280-crd: add dummy Bluetooth
 VDDIO supply

On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> Bluetooth requires VDDIO supply.  Due to lack of schematics provide
> something dummy to satisfy `dtbs_check`:
> 
>   sc7280-crd-r3.dtb: bluetooth: 'vddio-supply' is a required property
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
For this:

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

+CC Doug to perhaps fix this properly (though I think we should have got
it through the cros list anyway)

Konrad
>  arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
> index afae7f46b050..b1aa5b0ee95c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
> @@ -24,6 +24,13 @@ aliases {
>  	chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
> +
> +	bt_vddio: regulator-bt-vddio {
> +		compatible = "regulator-fixed";
> +		regulator-name = "bt-vddio";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +	};
>  };
>  
>  &apps_rsc {
> @@ -38,6 +45,10 @@ vreg_s1k_1p0: smps1 {
>  	};
>  };
>  
> +&bluetooth {
> +	vddio-supply = <&bt_vddio>;
> +};
> +
>  ap_tp_i2c: &i2c0 {
>  	status = "okay";
>  	clock-frequency = <400000>;