linux-kernel - Re: [PATCH 10/15] arm64: dts: qcom: sc8180x: use generic ADC channel node names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <abddd4e4-86b1-fd04-846f-e9ed498f5c80@linaro.org>
Date:   Mon, 19 Jun 2023 15:14:43 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        cros-qcom-dts-watchers@...omium.org,
        Nikita Travkin <nikita@...n.ru>,
        Stephan Gerhold <stephan@...hold.net>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/15] arm64: dts: qcom: sc8180x: use generic ADC channel
 node names

On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> ADC channel node names were changed to require generic 'channel'.  The
> user-visible part is defined via label.
> 
>   sc8180x-lenovo-flex-5g.dtb: adc@...0: 'die-temp@6', 'ref-gnd@0', 'vref-1p25@1' do not match any of the regexes: '^channel@[0-9a-f]+$', 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi | 24 ++++++++++-----------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
> index 8247af01c84a..4556af6cd103 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
> @@ -105,19 +105,19 @@ pmc8180_adc: adc@...0 {
>  			#io-channel-cells = <1>;
>  			interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
>  
> -			ref-gnd@0 {
> +			channel@0 {
>  				reg = <ADC5_REF_GND>;
>  				qcom,pre-scaling = <1 1>;
>  				label = "ref_gnd";
>  			};
>  
> -			vref-1p25@1 {
> +			channel@1 {
>  				reg = <ADC5_1P25VREF>;
>  				qcom,pre-scaling = <1 1>;
>  				label = "vref_1p25";
>  			};
>  
> -			die-temp@6 {
> +			channel@6 {
>  				reg = <ADC5_DIE_TEMP>;
>  				qcom,pre-scaling = <1 1>;
>  				label = "die_temp";
> @@ -172,19 +172,19 @@ adc@...0 {
>  			#io-channel-cells = <1>;
>  			interrupts = <0x2 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
>  
> -			ref-gnd@0 {
> +			channel@0 {
>  				reg = <ADC5_REF_GND>;
>  				qcom,pre-scaling = <1 1>;
>  				label = "ref_gnd";
>  			};
>  
> -			vref-1p25@1 {
> +			channel@1 {
>  				reg = <ADC5_1P25VREF>;
>  				qcom,pre-scaling = <1 1>;
>  				label = "vref_1p25";
>  			};
>  
> -			vcoin@85 {
> +			channel@85 {
>  				reg = <0x85>;
>  				qcom,pre-scaling = <1 1>;
>  				label = "vcoin2";
> @@ -220,19 +220,19 @@ adc@...0 {
>  			#io-channel-cells = <1>;
>  			interrupts = <0xa 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
>  
> -			ref-gnd@0 {
> +			channel@0 {
>  				reg = <ADC5_REF_GND>;
>  				qcom,pre-scaling = <1 1>;
>  				label = "ref_gnd";
>  			};
>  
> -			vref-1p25@1 {
> +			channel@1 {
>  				reg = <ADC5_1P25VREF>;
>  				qcom,pre-scaling = <1 1>;
>  				label = "vref_1p25";
>  			};
>  
> -			vcoin@85 {
> +			channel@85 {
>  				reg = <0x85>;
>  				qcom,pre-scaling = <1 1>;
>  				label = "vcoin";
> @@ -270,19 +270,19 @@ pmc8180c_adc: adc@...0 {
>  			#io-channel-cells = <1>;
>  			interrupts = <0x4 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
>  
> -			ref-gnd@0 {
> +			channel@0 {
>  				reg = <ADC5_REF_GND>;
>  				qcom,pre-scaling = <1 1>;
>  				label = "ref_gnd";
>  			};
>  
> -			vref-1p25@1 {
> +			channel@1 {
>  				reg = <ADC5_1P25VREF>;
>  				qcom,pre-scaling = <1 1>;
>  				label = "vref_1p25";
>  			};
>  
> -			die-temp@6 {
> +			channel@6 {
>  				reg = <ADC5_DIE_TEMP>;
>  				qcom,pre-scaling = <1 1>;
>  				label = "die_temp";