linux-kernel - Re: [PATCH v3 1/3] perf test: Add metric value validation test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <93574312-f467-04af-92af-5b5476043977@amd.com>
Date:   Mon, 19 Jun 2023 09:50:40 +0530
From:   Ravi Bangoria <ravi.bangoria@....com>
To:     "Wang, Weilin" <weilin.wang@...el.com>
Cc:     Kan Liang <kan.liang@...ux.intel.com>,
        "Alt, Samantha" <samantha.alt@...el.com>,
        "Taylor, Perry" <perry.taylor@...el.com>,
        "Biggers, Caleb" <caleb.biggers@...el.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        "Hunter, Adrian" <adrian.hunter@...el.com>,
        Ian Rogers <irogers@...gle.com>,
        "linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ravi Bangoria <ravi.bangoria@....com>
Subject: Re: [PATCH v3 1/3] perf test: Add metric value validation test

>>> +grep -q Intel /proc/cpuinfo || (echo Skipping non-Intel; exit 2)
>>
>> This check doesn't seem to be working. On my Zen3 AMD machine:
> 
> Thanks for reporting this! I've update this search to "GenuineIntel" in v4 to help solve this issue. 
> Please check it out. 

I'm sorry. I should have been more elaborative.

What I mean was () in bash creates a sub shell and thus exits from
the sub shell. I think what you need is {}. Ex:

  grep -q Intel /proc/cpuinfo || { echo Skipping non-Intel; exit 2; }


>>   test child finished with 0
>>   ---- end ----
>>   perf metrics value validation: Ok
>>
>> I haven't yet investigated whether it's genuine or false positive.
>>
> Base on this final report, it validated some basic rules like the 12 metrics for positive value test and 2 metrics for single metric value checks. 
> The test script grabs metrics supported on the platform and generates validation rules that only include metrics in the supported list. 
> Therefore, it is not surprising that the check passes on your system. 

Got it.

Thanks,
Ravi