linux-kernel - Re: linux-next: Fixes tag needs some work in the block tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a6f86f61-a054-2d31-92ee-0241c44a8ae6@nvidia.com>
Date:   Tue, 20 Jun 2023 05:41:11 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Jens Axboe <axboe@...nel.dk>,
        Alasdair G Kergon <agk@...hat.com>,
        Mike Snitzer <snitzer@...nel.org>
CC:     Chaitanya Kulkarni <chaitanyak@...dia.com>,
        Keith Busch <kbusch@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the block tree

On 6/18/23 15:22, Stephen Rothwell wrote:
> Hi all,
>
> [Also in the device-mapper tree]
>
> In commit
>
>    900095bfbbf6 ("nvme-fabrics: error out to unlock the mutex")
>
> Fixes tag
>
>    Fixes: f0cebf82004d ("nvme-fabrics: prevent overriding of existing host")
sorry I didn't understand this with above tag I could format a patch
that leads to above subject line :-

nvme (nvme-6.5) # git format-patch f0cebf82004d -1
0001-nvme-fabrics-prevent-overriding-of-existing-host.patch
  directory
nvme (nvme-6.5) # cat 
0001-nvme-fabrics-prevent-overriding-of-existing-host.patch
 From f0cebf82004d610be3ef47abf315ddf95aa2dcd1 Mon Sep 17 00:00:00 2001
From: Max Gurtovoy <mgurtovoy@...dia.com>
Date: Fri, 12 May 2023 18:41:55 +0300
Subject: [PATCH] nvme-fabrics: prevent overriding of existing host

When first connecting a target using the "default" host parameters,
setting the hostid from the command line during a subsequent connection
establishment would override the "default" hostid parameter. This would
cause an existing connection that is already using the host definitions
to lose its hostid.

To address this issue, the code has been modified to allow only 1:1
mapping between hostnqn and hostid. This will maintain unambiguous host
identification. Any non 1:1 mapping will be rejected during connection
establishment.

Tested-by: Noam Gottlieb <ngottlieb@...dia.com>
Reviewed-by: Israel Rukshin <israelr@...dia.com>
Signed-off-by: Max Gurtovoy <mgurtovoy@...dia.com>
Reviewed-by: Christoph Hellwig <hch@....de>
Signed-off-by: Keith Busch <kbusch@...nel.org>
---

> has these problem(s):
>
>    - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: ae8bd606e09b ("nvme-fabrics: prevent overriding of existing host")
>