linux-kernel - Re: [PATCH] drivers/staging/rtl8192e Style guide whitespace cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 20 Jun 2023 07:43:24 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tree Davies <tdavies@...kphysics.net>
Cc:     philipp.g.hortmann@...il.com, t4rmin@...omail.com,
        colin.i.king@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/staging/rtl8192e Style guide whitespace cleanup

On Mon, Jun 19, 2023 at 06:13:55PM -0700, Tree Davies wrote:

> >From 25f4faf714f0e957996b9245f7e8c219080ad69b Mon Sep 17 00:00:00 2001
> From: Tree Davies <tdavies@...kphysics.net>
> Date: Mon, 19 Jun 2023 17:31:47 -0700
> Subject: [PATCH] drivers/staging/rtl8192e Style guide whitespace cleanup
> 
> This patch cleans up extraneous whitespace for the
> struct rt_hi_throughput definition.
> 
> Signed-off-by: Tree Davies <tdavies@...kphysics.net>
> ---
>  drivers/staging/rtl8192e/rtl819x_HT.h | 63 ++++++++++-----------------
>  1 file changed, 23 insertions(+), 40 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h
> index f4e9fa849796..f5ab19694f1a 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HT.h
> +++ b/drivers/staging/rtl8192e/rtl819x_HT.h
> @@ -96,70 +96,53 @@ enum ht_aggre_mode {
>  
>  
>  struct rt_hi_throughput {
> -	u8				enable_ht;
> -	u8				bCurrentHTSupport;
> -
> -	u8				bRegBW40MHz;
> -	u8				bCurBW40MHz;
> -
> -	u8				bRegShortGI40MHz;
> -	u8				bCurShortGI40MHz;
> -
> -	u8				bRegShortGI20MHz;
> -	u8				bCurShortGI20MHz;
> -
> -	u8				bRegSuppCCK;
> -	u8				bCurSuppCCK;
> -
> +	u8 enable_ht;
> +	u8 bCurrentHTSupport;
> +	u8 bRegBW40MHz;
> +	u8 bCurBW40MHz;
> +	u8 bRegShortGI40MHz;
> +	u8 bCurShortGI40MHz;
> +	u8 bRegShortGI20MHz;
> +	u8 bCurShortGI20MHz;
> +	u8 bRegSuppCCK;
> +	u8 bCurSuppCCK;
>  	enum ht_spec_ver ePeerHTSpecVer;
> -
> -
>  	struct ht_capab_ele SelfHTCap;
>  	struct ht_info_ele SelfHTInfo;
> -
> -	u8				PeerHTCapBuf[32];
> -	u8				PeerHTInfoBuf[32];
> -
> -
> -	u8				bAMSDU_Support;
> -	u16				nAMSDU_MaxSize;
> -	u8				bCurrent_AMSDU_Support;
> -	u16				nCurrent_AMSDU_MaxSize;
> -
> -	u8				bAMPDUEnable;
> -	u8				bCurrentAMPDUEnable;
> -	u8				AMPDU_Factor;
> -	u8				CurrentAMPDUFactor;
> -	u8				MPDU_Density;
> +	u8 PeerHTCapBuf[32];
> +	u8 PeerHTInfoBuf[32];
> +	u8 bAMSDU_Support;
> +	u16	nAMSDU_MaxSize;
> +	u8 bCurrent_AMSDU_Support;
> +	u16	nCurrent_AMSDU_MaxSize;
> +	u8 bAMPDUEnable;
> +	u8 bCurrentAMPDUEnable;
> +	u8 AMPDU_Factor;
> +	u8 CurrentAMPDUFactor;
> +	u8 MPDU_Density;
>  	u8 current_mpdu_density;
> -
>  	enum ht_aggre_mode ForcedAMPDUMode;
>  	u8 forced_ampdu_factor;
>  	u8 forced_mpdu_density;
> -
>  	enum ht_aggre_mode ForcedAMSDUMode;
>  	u8 forced_short_gi;
> -
>  	u8 current_op_mode;
> -
>  	u8 self_mimo_ps;
>  	u8 peer_mimo_ps;
> -
>  	enum ht_extchnl_offset CurSTAExtChnlOffset;
>  	u8 cur_tx_bw40mhz;
>  	u8 sw_bw_in_progress;
>  	u8 reg_rt2rt_aggregation;
> -	u8				RT2RT_HT_Mode;
> +	u8 RT2RT_HT_Mode;
>  	u8 current_rt2rt_aggregation;
>  	u8 current_rt2rt_long_slot_time;
>  	u8 sz_rt2rt_agg_buf[10];
> -
>  	u8 reg_rx_reorder_enable;
>  	u8 cur_rx_reorder_enable;
>  	u8 rx_reorder_win_size;
>  	u8 rx_reorder_pending_time;
>  	u16 rx_reorder_drop_counter;
> -	u8				IOTPeer;
> +	u8 IOTPeer;
>  	u32 iot_action;
>  	u8 iot_ra_func;
>  } __packed;
> -- 
> 2.39.2
> 


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch was attached, please place it inline so that it can be
  applied directly from the email message itself.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot