linux-kernel - RE: [PATCH v8 4/6] gpio: Add support for Intel LJCA USB GPIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB4316BEB6C6D34F38465A33DE8D5CA@DM6PR11MB4316.namprd11.prod.outlook.com>
Date:   Tue, 20 Jun 2023 07:00:19 +0000
From:   "Wu, Wentong" <wentong.wu@...el.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        "Ye, Xiang" <xiang.ye@...el.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Matthias Kaehlcke <mka@...omium.org>,
        Lee Jones <lee@...nel.org>, Wolfram Sang <wsa@...nel.org>,
        Tyrone Ting <kfting@...oton.com>,
        Mark Brown <broonie@...nel.org>, Marc Zyngier <maz@...nel.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "Pandruvada, Srinivas" <srinivas.pandruvada@...el.com>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>,
        "Wang, Zhifeng" <zhifeng.wang@...el.com>,
        "Zhang, Lixu" <lixu.zhang@...el.com>
Subject: RE: [PATCH v8 4/6] gpio: Add support for Intel LJCA USB GPIO driver



> -----Original Message-----
> From: Linus Walleij <linus.walleij@...aro.org>
> Sent: Friday, May 12, 2023 5:08 AM
> 
> > +static int gpio_config(struct ljca_gpio_dev *ljca_gpio, u8 gpio_id,
> > +u8 config)
> 
> All other functions are prefixed ljca_* except this one, so I think you should do
> that on this one too.

Thank you, Linus, this will be fixed in next version, Thanks

> 
> With that fixes:
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> 
> Yours,
> Linus Walleij