linux-kernel - RE: [PATCH v8 5/6] i2c: Add support for Intel LJCA USB I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB431671A0D56D284625ECD4FD8D5CA@DM6PR11MB4316.namprd11.prod.outlook.com>
Date:   Tue, 20 Jun 2023 06:57:07 +0000
From:   "Wu, Wentong" <wentong.wu@...el.com>
To:     Oliver Neukum <oneukum@...e.com>, "Ye, Xiang" <xiang.ye@...el.com>
CC:     Arnd Bergmann <arnd@...db.de>,
        Matthias Kaehlcke <mka@...omium.org>,
        "Lee Jones" <lee@...nel.org>, Wolfram Sang <wsa@...nel.org>,
        Tyrone Ting <kfting@...oton.com>,
        Mark Brown <broonie@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Marc Zyngier <maz@...nel.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "Pandruvada, Srinivas" <srinivas.pandruvada@...el.com>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>,
        "Wang, Zhifeng" <zhifeng.wang@...el.com>,
        "Zhang, Lixu" <lixu.zhang@...el.com>
Subject: RE: [PATCH v8 5/6] i2c: Add support for Intel LJCA USB I2C driver

Hi Oliver,

Thanks for your review.

> -----Original Message-----
> From: Oliver Neukum <oneukum@...e.com>
> Sent: Monday, May 22, 2023 5:50 PM
> 
> On 11.05.23 19:58, Ye Xiang wrote:
> > Implements the I2C function of Intel USB-I2C/GPIO/SPI adapter device
> > named "La Jolla Cove Adapter" (LJCA). It communicate with LJCA I2c
> > module with specific protocol through interfaces exported by LJCA USB
> > driver.
> 
> > +/* I2C Transfer */
> > +struct i2c_xfer {
> > +	u8 id;
> > +	u8 slave;
> > +	u16 flag; /* speed, 8/16bit addr, addr increase, etc */
> > +	u16 addr;
> > +	u16 len;
> > +	u8 data[];
> > +} __packed;
> 
> Where is this needed?

Yes, you're right, we don’t need this structure. Thanks 

> Why is it defined __packed, yet the internal endianness is not declared?
> 
> 	Regards
> 		Oliver