linux-kernel - Re: [PATCH 2/5] staging: rtl8723bs: Fix space issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Jun 2023 16:12:33 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Franziska Naepelt <franziska.naepelt@...glemail.com>
Cc:     eperi1024@...il.com, franziska.naepelt@...il.com,
        hdegoede@...hat.com, johannes.berg@...el.com,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
        quic_vjakkam@...cinc.com, tegongkang@...il.com
Subject: Re: [PATCH 2/5] staging: rtl8723bs: Fix space issues

On Mon, Jun 19, 2023 at 08:07:53PM +0200, Franziska Naepelt wrote:
> Fix the following checkpatch space issues:
> - CHECK: spaces preferred around that '*' (ctx:VxV)
> - CHECK: spaces preferred around that '+' (ctx:VxV)
> - CHECK: spaces preferred around that '-' (ctx:VxV)
> - CHECK: spaces preferred around that '|' (ctx:VxV)
> - CHECK: No space is necessary after a cast
> - WARNING: please, no spaces at the start of a line
> 
> Signed-off-by: Franziska Naepelt <franziska.naepelt@...il.com>
> ---
>  .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 77 +++++++++----------
>  1 file changed, 38 insertions(+), 39 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> index 1afd1a93bcee..abda4e0f0bf5 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> @@ -95,14 +95,14 @@ static struct ieee80211_channel rtw_2ghz_channels[] = {
>  static void rtw_2g_channels_init(struct ieee80211_channel *channels)
>  {
>  	memcpy((void *)channels, (void *)rtw_2ghz_channels,
> -		sizeof(struct ieee80211_channel)*RTW_2G_CHANNELS_NUM
> +		sizeof(struct ieee80211_channel) * RTW_2G_CHANNELS_NUM
>  	);
>  }
>  
>  static void rtw_2g_rates_init(struct ieee80211_rate *rates)
>  {
>  	memcpy(rates, rtw_g_rates,
> -		sizeof(struct ieee80211_rate)*RTW_G_RATES_NUM
> +		sizeof(struct ieee80211_rate) * RTW_G_RATES_NUM
>  	);
>  }
>  
> @@ -126,8 +126,8 @@ static struct ieee80211_supported_band *rtw_spt_band_alloc(
>  	if (!spt_band)
>  		goto exit;
>  
> -	spt_band->channels = (struct ieee80211_channel *)(((u8 *)spt_band)+sizeof(struct ieee80211_supported_band));
> -	spt_band->bitrates = (struct ieee80211_rate *)(((u8 *)spt_band->channels)+sizeof(struct ieee80211_channel)*n_channels);
> +	spt_band->channels = (struct ieee80211_channel *)(((u8 *)spt_band) + sizeof(struct ieee80211_supported_band));
> +	spt_band->bitrates = (struct ieee80211_rate *)(((u8 *)spt_band->channels) + sizeof(struct ieee80211_channel) * n_channels);
>  	spt_band->band = band;
>  	spt_band->n_channels = n_channels;
>  	spt_band->n_bitrates = n_bitrates;
> @@ -247,10 +247,10 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct adapter *padapter, struct wl
>  		u32 wpsielen = 0;
>  		u8 *wpsie = NULL;
>  
> -		wpsie = rtw_get_wps_ie(pnetwork->network.ies+_FIXED_IE_LENGTH_, pnetwork->network.ie_length-_FIXED_IE_LENGTH_, NULL, &wpsielen);
> +		wpsie = rtw_get_wps_ie(pnetwork->network.ies + _FIXED_IE_LENGTH_, pnetwork->network.ie_length - _FIXED_IE_LENGTH_, NULL, &wpsielen);
>  
>  		if (wpsie && wpsielen > 0)
> -			psr = rtw_get_wps_attr_content(wpsie,  wpsielen, WPS_ATTR_SELECTED_REGISTRAR, (u8 *)(&sr), NULL);
> +			psr = rtw_get_wps_attr_content(wpsie, wpsielen, WPS_ATTR_SELECTED_REGISTRAR, (u8 *)(&sr), NULL);
>  
>  		if (sr != 0) {
>  			/* it means under processing WPS */
> @@ -266,7 +266,6 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct adapter *padapter, struct wl
>  	}
>  	/* spin_unlock_bh(&pwdev_priv->scan_req_lock); */
>  
> -

This was an extra blank line issue that you did not mention in the
changelog :(

Please be more careful.

thanks,

greg k-h