linux-kernel - Re: [PATCH 1/4] dt-bindings: intel: Add Intel Agilex5 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230620141212.2469148-1-niravkumar.l.rabara@intel.com>
Date:   Tue, 20 Jun 2023 22:12:12 +0800
From:   niravkumar.l.rabara@...el.com
To:     krzysztof.kozlowski@...aro.org
Cc:     adrian.ho.yin.ng@...el.com, andrew@...n.ch, conor+dt@...nel.org,
        devicetree@...r.kernel.org, dinguyen@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, mturquette@...libre.com,
        netdev@...r.kernel.org, niravkumar.l.rabara@...el.com,
        p.zabel@...gutronix.de, richardcochran@...il.com,
        robh+dt@...nel.org, sboyd@...nel.org, wen.ping.teh@...el.com
Subject: Re: [PATCH 1/4] dt-bindings: intel: Add Intel Agilex5 compatible

>> diff --git a/Documentation/devicetree/bindings/arm/intel,socfpga.yaml 
>> b/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
>> index 4b4dcf551eb6..28849c720314 100644
>> --- a/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
>> +++ b/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
>> @@ -20,6 +20,7 @@ properties:
>>                - intel,n5x-socdk
>>                - intel,socfpga-agilex-n6000
>>                - intel,socfpga-agilex-socdk
>> +              - intel,socfpga-agilex5-socdk
>>            - const: intel,socfpga-agilex
>
>This is agilex5, not agilex. Why are you using the same SoC compatible?
>You have entire commit msg to explain your hardware and avoid such questions...

Yes, better to use different SoC compatible for Agilex5,
will add new description and item for Agilex5 board in v2 patch.