linux-kernel - Re: [PATCH net v3 1/1] net: phy: nxp-c45-tja11xx: fix the PTP interrupt enablig/disabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Jun 2023 20:31:45 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Radu Pirea (NXP OSS)" <radu-nicolae.pirea@....nxp.com>
Cc:     andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        richardcochran@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, sebastian.tobuschat@....com,
        stable@...r.kernel.org
Subject: Re: [PATCH net v3 1/1] net: phy: nxp-c45-tja11xx: fix the PTP
 interrupt enablig/disabling

On Mon, 19 Jun 2023 16:28:51 +0300 Radu Pirea (NXP OSS) wrote:
> Subject: [PATCH net v3 1/1] net: phy: nxp-c45-tja11xx: fix the PTP interrupt enablig/disabling

typo: enablig -> enabling

> .config_intr() handles only the link event interrupt and should
> disable/enable the PTP interrupt also.

I don't understand this sentence, TBH, could you rephrase?

> Fixes: 514def5dd339 ("phy: nxp-c45-tja11xx: add timestamping support")

For a fix we really need to commit message to say what the problem is,
in terms which will be understood by the user. User visible behavior.

> CC: stable@...r.kernel.org # 5.15+
> Signed-off-by: Radu Pirea (NXP OSS) <radu-nicolae.pirea@....nxp.com>
> ---
> 
> Where is V1?
> https://patchwork.kernel.org/project/netdevbpf/patch/20230410124856.287753-1-radu-nicolae.pirea@oss.nxp.com/
> 
> Where is V2?
> https://patchwork.kernel.org/project/netdevbpf/patch/20230616135323

This link looks cut off.

> +	/* 0x807A register is not present on SJA1110 PHYs. */

Meaning? It's safe because the operation will be ignored?
-- 
pw-bot: cr