linux-kernel - Re: [PATCH net v3 1/1] net: phy: nxp-c45-tja11xx: fix the PTP interrupt enablig/disabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b7365082-55e4-44c4-88d7-3d5c65de8406@oss.nxp.com>
Date:   Wed, 21 Jun 2023 19:18:28 +0300
From:   "Radu Pirea (OSS)" <radu-nicolae.pirea@....nxp.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        richardcochran@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, sebastian.tobuschat@....com,
        stable@...r.kernel.org
Subject: Re: [PATCH net v3 1/1] net: phy: nxp-c45-tja11xx: fix the PTP
 interrupt enablig/disabling

Hi Jakub,

On 21.06.2023 06:31, Jakub Kicinski wrote:
> On Mon, 19 Jun 2023 16:28:51 +0300 Radu Pirea (NXP OSS) wrote:
>> Subject: [PATCH net v3 1/1] net: phy: nxp-c45-tja11xx: fix the PTP interrupt enablig/disabling
> 
> typo: enablig -> enabling
> 
>> .config_intr() handles only the link event interrupt and should
>> disable/enable the PTP interrupt also.
> 
> I don't understand this sentence, TBH, could you rephrase? >
>> Fixes: 514def5dd339 ("phy: nxp-c45-tja11xx: add timestamping support")
> 
> For a fix we really need to commit message to say what the problem is,
> in terms which will be understood by the user. User visible behavior.

If tools like ptp4l are killed, will leave egress timestamp interrupt 
enabled. And I would like to say that I was able to trigger any bug 
related to this, but I wasn't. So, I don't have any bad behaviour to 
describe :)

However, now I realize that disabling all the PTP IRQs is not a smart 
way to fix this virtual pseudo issue.

> 
>> CC: stable@...r.kernel.org # 5.15+
>> Signed-off-by: Radu Pirea (NXP OSS) <radu-nicolae.pirea@....nxp.com>
>> ---
>>
>> Where is V1?
>> https://patchwork.kernel.org/project/netdevbpf/patch/20230410124856.287753-1-radu-nicolae.pirea@oss.nxp.com/
>>
>> Where is V2?
>> https://patchwork.kernel.org/project/netdevbpf/patch/20230616135323
> 
> This link looks cut off.

https://patchwork.kernel.org/project/netdevbpf/patch/20230616135323.98215-2-radu-nicolae.pirea@oss.nxp.com/

> 
>> +     /* 0x807A register is not present on SJA1110 PHYs. */
> 
> Meaning? It's safe because the operation will be ignored?

Yes. The PHY will ignore the writes and will return 0 on reads.

> --
> pw-bot: cr

-- 
Radu P.