linux-kernel - Re: [PATCH v2 1/1] net: axienet: Move reset before DMA detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e57290b0f995bb05d07d48e0df3a77c526242168.camel@calian.com>
Date:   Thu, 22 Jun 2023 18:02:03 +0000
From:   Robert Hancock <robert.hancock@...ian.com>
To:     "fido_max@...ox.ru" <fido_max@...ox.ru>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "andrew@...n.ch" <andrew@...n.ch>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "michal.simek@....com" <michal.simek@....com>,
        "radhey.shyam.pandey@....com" <radhey.shyam.pandey@....com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "kuba@...nel.org" <kuba@...nel.org>
Subject: Re: [PATCH v2 1/1] net: axienet: Move reset before DMA detection

On Thu, 2023-06-22 at 20:52 +0300, Maxim Kochetkov wrote:
> DMA detection will fail if axinet was started before (by boot loader,
> boot ROM, etc). In this state axinet will not start properly.
> XAXIDMA_TX_CDESC_OFFSET + 4 register (MM2S_CURDESC_MSB) is used to
> detect
> 64 DMA capability here. But datasheet says: When DMACR.RS is 1
> (axinet is in enabled state), CURDESC_PTR becomes Read Only (RO) and
> is used to fetch the first descriptor. So iowrite32()/ioread32()
> trick
> to this register to detect DMA will not work.
> So move axinet reset before DMA detection.
> 
> Fixes: 04cc2da39698 ("net: axienet: reset core on initialization
> prior to MDIO access")
> Signed-off-by: Maxim Kochetkov <fido_max@...ox.ru>
> 

Reviewed-by: Robert Hancock <robert.hancock@...ian.com>

> ---
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 3e310b55bce2..734822321e0a 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -2042,6 +2042,11 @@ static int axienet_probe(struct
> platform_device *pdev)
>                 goto cleanup_clk;
>         }
> 
> +       /* Reset core now that clocks are enabled, prior to accessing
> MDIO */
> +       ret = __axienet_device_reset(lp);
> +       if (ret)
> +               goto cleanup_clk;
> +
>         /* Autodetect the need for 64-bit DMA pointers.
>          * When the IP is configured for a bus width bigger than 32
> bits,
>          * writing the MSB registers is mandatory, even if they are
> all 0.
> @@ -2096,11 +2101,6 @@ static int axienet_probe(struct
> platform_device *pdev)
>         lp->coalesce_count_tx = XAXIDMA_DFT_TX_THRESHOLD;
>         lp->coalesce_usec_tx = XAXIDMA_DFT_TX_USEC;
> 
> -       /* Reset core now that clocks are enabled, prior to accessing
> MDIO */
> -       ret = __axienet_device_reset(lp);
> -       if (ret)
> -               goto cleanup_clk;
> -
>         ret = axienet_mdio_setup(lp);
>         if (ret)
>                 dev_warn(&pdev->dev,
> --
> 2.40.1
>