linux-kernel - RE: [PATCH 2/2] selftests: add OFD lock tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a2001d9a52f$cfd24450$6f76ccf0$@mindspring.com>
Date:   Thu, 22 Jun 2023 10:34:33 -0700
From:   "Frank Filz" <ffilzlnx@...dspring.com>
To:     "'Chuck Lever III'" <chuck.lever@...cle.com>,
        "'stsp'" <stsp2@...dex.ru>
Cc:     "'Jeff Layton'" <jlayton@...nel.org>,
        <linux-kernel@...r.kernel.org>,
        "'Al Viro'" <viro@...iv.linux.org.uk>,
        "'Christian Brauner'" <brauner@...nel.org>,
        <linux-fsdevel@...r.kernel.org>, "'Shuah Khan'" <shuah@...nel.org>,
        <linux-kselftest@...r.kernel.org>, <linux-api@...r.kernel.org>
Subject: RE: [PATCH 2/2] selftests: add OFD lock tests

> > On Jun 22, 2023, at 1:05 PM, stsp <stsp2@...dex.ru> wrote:
> >
> >
> > 22.06.2023 21:58, Chuck Lever III пишет:
> >> IMO that's not a reason not to do this properly.
> >>
> >> You should work with Jeff and the maintainer of xfstests to make it
> >> happen.
> > But its not going to be in this patch-set anyway, as its a different
> > source tree...
> 
> If others agree with me, then please drop the selftests patch from this series.
> There is a considerably higher probability that the new test will be run frequently
> by CI if it's in xfstests.
> 
> 
> > So I should prepare it when this is merged, or?
> 
> I don't have a strong preference. A good choice is to push the test before the
> kernel changes are merged.

As an aside, an additional testing option for OFD locks is the multilock test tool that is in the nfs-ganesha project. In preparation to use OFD locks in Ganesha, I added them to multilock to check them out, and that incidentally also allows testing how the NFS client and server work when OFD locks are taken on a file from an NFS mount.

Frank