linux-kernel - Re: [PATCH v6 03/27] cxl: Updates for CXL Test to work with RCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb2ca23e-dbde-7e1c-8e3c-3163292fd824@amd.com>
Date:   Thu, 22 Jun 2023 09:02:50 -0500
From:   Terry Bowman <Terry.Bowman@....com>
To:     Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc:     alison.schofield@...el.com, vishal.l.verma@...el.com,
        ira.weiny@...el.com, bwidawsk@...nel.org, dan.j.williams@...el.com,
        dave.jiang@...el.com, linux-cxl@...r.kernel.org, rrichter@....com,
        linux-kernel@...r.kernel.org, bhelgaas@...gle.com
Subject: Re: [PATCH v6 03/27] cxl: Updates for CXL Test to work with RCH

Hi Jonathan,

On 6/22/23 04:53, Jonathan Cameron wrote:
> On Wed, 21 Jun 2023 22:51:02 -0500
> Terry Bowman <terry.bowman@....com> wrote:
> 
>> From: Dan Williams <dan.j.williams@...el.com>
>>
>> CXL test needs to be updated to work with latest RCH changes.
>> Add CXL test support for devm_cxl_add_rch_dport and
>> cxl_rcd_component_reg_phys functions.
>>
>> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
>> Signed-off-by: Terry Bowman <terry.bowman@....com>
>> Signed-off-by: Robert Richter <rrichter@....com>
> 
> This chain is getting confusing.
> 
> Why a SoB from Robert on this one?
> As Terry sent the series I'd expect Terry to be last unless there
> was some codevelopment involved in which case that should be indicated
> in the tags.
> 

This was a mistake on my part. I'll remove Robert. Thanks for pointing out.

Regards,
Terry

> For weird corner cases it's worth adding some comments on why a SoB chain
> is non obvious.
> 
> I'm far from an expert on cxl-test so I'll leave reviewing this in
> depth to others.  FWIW looks fine to me.
> 
> Jonathan
>