linux-kernel - Re: [PATCH v1 01/12] perf expr: Add has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP-5=fWEgiF0Gg9B3UqyDDvcSR6z=xJUoX7ZiBWeV6+qd+AtfA@mail.gmail.com>
Date:   Fri, 23 Jun 2023 08:00:59 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     John Garry <john.g.garry@...cle.com>
Cc:     eter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Zhengjun Xing <zhengjun.xing@...ux.intel.com>,
        Kajol Jain <kjain@...ux.ibm.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Eduard Zingerman <eddyz87@...il.com>,
        Jing Zhang <renyu.zj@...ux.alibaba.com>,
        Sohom Datta <sohomdatta1@...il.com>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Perry Taylor <perry.taylor@...el.com>,
        Samantha Alt <samantha.alt@...el.com>,
        Caleb Biggers <caleb.biggers@...el.com>,
        Weilin Wang <weilin.wang@...el.com>,
        Edward Baker <edward.baker@...el.com>
Subject: Re: [PATCH v1 01/12] perf expr: Add has_event function

On Fri, Jun 23, 2023 at 7:40 AM John Garry <john.g.garry@...cle.com> wrote:
>
> On 23/06/2023 01:33, Ian Rogers wrote:
> > +     if (!compute_ids)
> > +             return 0.0;
> > +
> > +     tmp = evlist__new();
>
> tmp may be NULL, and parse_event() is not NULL safe, so I assume that we
> need to handle tmp == NULL

I'm not sure there's much sensible we can do with this, so I'll turn
it into a NAN for v2 - the normal error case.

Thanks,
Ian

> > +     ret = parse_event(tmp, id) ? 0 : 1;
> > +     evlist__delete(tmp);
> > +     return ret;
>