linux-kernel - Re: [PATCH v2 12/45] dt-bindings: reset: atmel,at91sam9260-reset: add sam9x7 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <703ed392-5607-446e-e59a-8b51b6cd0007@linaro.org>
Date:   Sat, 24 Jun 2023 09:57:20 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Varshini Rajendran <varshini.rajendran@...rochip.com>,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, nicolas.ferre@...rochip.com,
        alexandre.belloni@...tlin.com, claudiu.beznea@...rochip.com,
        mturquette@...libre.com, sboyd@...nel.org,
        herbert@...dor.apana.org.au, davem@...emloft.net, vkoul@...nel.org,
        tglx@...utronix.de, maz@...nel.org, lee@...nel.org,
        ulf.hansson@...aro.org, tudor.ambarus@...aro.org,
        miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        linus.walleij@...aro.org, p.zabel@...gutronix.de,
        olivia@...enic.com, a.zummo@...ertech.it,
        radu_nicolae.pirea@....ro, richard.genoud@...il.com,
        gregkh@...uxfoundation.org, lgirdwood@...il.com,
        broonie@...nel.org, wim@...ux-watchdog.org, linux@...ck-us.net,
        arnd@...db.de, olof@...om.net, soc@...nel.org,
        linux@...linux.org.uk, sre@...nel.org, jerry.ray@...rochip.com,
        horatiu.vultur@...rochip.com, durai.manickamkr@...rochip.com,
        andrew@...n.ch, alain.volmat@...s.st.com,
        neil.armstrong@...aro.org, mihai.sain@...rochip.com,
        eugen.hristev@...labora.com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-crypto@...r.kernel.org,
        dmaengine@...r.kernel.org, linux-i2c@...r.kernel.org,
        linux-mmc@...r.kernel.org, linux-mtd@...ts.infradead.org,
        netdev@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-rtc@...r.kernel.org, linux-spi@...r.kernel.org,
        linux-serial@...r.kernel.org, alsa-devel@...a-project.org,
        linux-usb@...r.kernel.org, linux-watchdog@...r.kernel.org,
        linux-pm@...r.kernel.org
Cc:     Hari.PrasathGE@...rochip.com, cristian.birsan@...rochip.com,
        balamanikandan.gunasundar@...rochip.com,
        manikandan.m@...rochip.com, dharma.b@...rochip.com,
        nayabbasha.sayed@...rochip.com, balakrishnan.s@...rochip.com
Subject: Re: [PATCH v2 12/45] dt-bindings: reset: atmel,at91sam9260-reset: add
 sam9x7 binding

On 23/06/2023 22:30, Varshini Rajendran wrote:
> Add documentation for SAM9X7 reset controller.
> 


A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.

> Signed-off-by: Varshini Rajendran <varshini.rajendran@...rochip.com>
> ---
>  .../devicetree/bindings/reset/atmel,at91sam9260-reset.yaml       | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/reset/atmel,at91sam9260-reset.yaml b/Documentation/devicetree/bindings/reset/atmel,at91sam9260-reset.yaml
> index 98465d26949e..593a13c277ab 100644
> --- a/Documentation/devicetree/bindings/reset/atmel,at91sam9260-reset.yaml
> +++ b/Documentation/devicetree/bindings/reset/atmel,at91sam9260-reset.yaml
> @@ -22,6 +22,7 @@ properties:
>                - atmel,at91sam9g45-rstc
>                - atmel,sama5d3-rstc
>                - microchip,sam9x60-rstc
> +              - microchip,sam9x7-rstc

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).


Best regards,
Krzysztof