lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <28a5d2e7-d3bf-d373-10ad-73c7590924c4@linaro.org>
Date:   Sat, 24 Jun 2023 09:58:52 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Varshini Rajendran <varshini.rajendran@...rochip.com>,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, nicolas.ferre@...rochip.com,
        alexandre.belloni@...tlin.com, claudiu.beznea@...rochip.com,
        mturquette@...libre.com, sboyd@...nel.org,
        herbert@...dor.apana.org.au, davem@...emloft.net, vkoul@...nel.org,
        tglx@...utronix.de, maz@...nel.org, lee@...nel.org,
        ulf.hansson@...aro.org, tudor.ambarus@...aro.org,
        miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        linus.walleij@...aro.org, p.zabel@...gutronix.de,
        olivia@...enic.com, a.zummo@...ertech.it,
        radu_nicolae.pirea@....ro, richard.genoud@...il.com,
        gregkh@...uxfoundation.org, lgirdwood@...il.com,
        broonie@...nel.org, wim@...ux-watchdog.org, linux@...ck-us.net,
        arnd@...db.de, olof@...om.net, soc@...nel.org,
        linux@...linux.org.uk, sre@...nel.org, jerry.ray@...rochip.com,
        horatiu.vultur@...rochip.com, durai.manickamkr@...rochip.com,
        andrew@...n.ch, alain.volmat@...s.st.com,
        neil.armstrong@...aro.org, mihai.sain@...rochip.com,
        eugen.hristev@...labora.com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-crypto@...r.kernel.org,
        dmaengine@...r.kernel.org, linux-i2c@...r.kernel.org,
        linux-mmc@...r.kernel.org, linux-mtd@...ts.infradead.org,
        netdev@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-rtc@...r.kernel.org, linux-spi@...r.kernel.org,
        linux-serial@...r.kernel.org, alsa-devel@...a-project.org,
        linux-usb@...r.kernel.org, linux-watchdog@...r.kernel.org,
        linux-pm@...r.kernel.org
Cc:     Hari.PrasathGE@...rochip.com, cristian.birsan@...rochip.com,
        balamanikandan.gunasundar@...rochip.com,
        manikandan.m@...rochip.com, dharma.b@...rochip.com,
        nayabbasha.sayed@...rochip.com, balakrishnan.s@...rochip.com
Subject: Re: [PATCH v2 14/45] dt-bindings: crypto: add bindings for sam9x7 in
 Atmel AES

On 23/06/2023 22:30, Varshini Rajendran wrote:
> Add DT bindings for atmel AES.
> 
> Signed-off-by: Varshini Rajendran <varshini.rajendran@...rochip.com>
> ---
>  .../devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml    | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml
> index 0b7383b3106b..f0736696c883 100644
> --- a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml
> +++ b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml
> @@ -12,7 +12,10 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: atmel,at91sam9g46-aes
> +    oneOf:

This is not oneOf.

> +      - items:

And these are not items. You just broke existing users, which points to
the fact that you did not test the bindings nor the DTS. You didn't test
anything here.

This comment applies for entire patchset - please test everything. I
expect v3, after testing.


Best regards,
Krzysztof

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ