linux-kernel - Re: [PATCH 2/3] hwmon: (sht3x) add device-tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb2f59a0-4054-c8a4-9d75-0ea354b92e3b@roeck-us.net>
Date:   Sat, 24 Jun 2023 09:34:57 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     JuenKit_Yip@...mail.com, jdelvare@...e.com,
        krzysztof.kozlowki+dt@...aro.org, conor+dt@...nel.org,
        broonie@...nel.org, vincent@...emblay.dev, michal.simek@....com,
        geert+renesas@...der.be
Cc:     linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] hwmon: (sht3x) add device-tree support

On 6/24/23 09:01, JuenKit_Yip@...mail.com wrote:
> From: JuenKit Yip <JuenKit_Yip@...mail.com>
> 
> add "compatible" property for supporting device-tree
> 
> Signed-off-by: JuenKit Yip <JuenKit_Yip@...mail.com>
> ---
>   drivers/hwmon/sht3x.c | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/sht3x.c b/drivers/hwmon/sht3x.c
> index 9b2dadd11eeb..e7648c011e5f 100644
> --- a/drivers/hwmon/sht3x.c
> +++ b/drivers/hwmon/sht3x.c
> @@ -925,8 +925,18 @@ static const struct i2c_device_id sht3x_ids[] = {
>   
>   MODULE_DEVICE_TABLE(i2c, sht3x_ids);
>   
> +/* devicetree ID table */
> +static const struct of_device_id sht3x_of_match[] = {
> +	{ .compatible = "sensirion,sht3x" },
> +	{ .compatible = "sensirion,sts3x" },
> +	{},
> +};

Add

MODULE_DEVICE_TABLE(of, sht3x_of_match);

> +
>   static struct i2c_driver sht3x_i2c_driver = {
> -	.driver.name = "sht3x",
> +	.driver = {
> +		.name = "sht3x",
> +		.of_match_table = of_match_ptr(sht3x_of_match),

Drop of_match_ptr().

> +	},
>   	.probe       = sht3x_probe,
>   	.id_table    = sht3x_ids,
>   };