linux-kernel - Re: [PATCH 3/3] dt-bindings: <hwmon>: add sht3x devicetree binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7422c2d-1a78-32a0-86a9-225d5880cbc2@roeck-us.net>
Date:   Sat, 24 Jun 2023 09:36:34 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     JuenKit_Yip@...mail.com, jdelvare@...e.com,
        krzysztof.kozlowki+dt@...aro.org, conor+dt@...nel.org,
        broonie@...nel.org, vincent@...emblay.dev, michal.simek@....com,
        geert+renesas@...der.be
Cc:     linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: <hwmon>: add sht3x devicetree binding

On 6/24/23 09:01, JuenKit_Yip@...mail.com wrote:
> From: JuenKit Yip <JuenKit_Yip@...mail.com>
> 
> add sht3x devicetree binding files
> 
> Signed-off-by: JuenKit Yip <JuenKit_Yip@...mail.com>
> ---
>   .../devicetree/bindings/hwmon/sht3x.yaml      | 31 +++++++++++++++++++

This isn't needed if the compatibles are added to trivial-devices.yaml
(and it really only makes sense if there are additional properties
besides compatible).

Guenter

>   .../devicetree/bindings/trivial-devices.yaml  |  4 +++
>   2 files changed, 35 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/hwmon/sht3x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/sht3x.yaml b/Documentation/devicetree/bindings/hwmon/sht3x.yaml
> new file mode 100644
> index 000000000000..8ff0b8d41f91
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/sht3x.yaml
> @@ -0,0 +1,31 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +% YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/sensirion,sht3x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sensirion SHT3x-DIS humidity and temperature sensor
> +
> +maintainers:
> +  - JuenKit Yip <JuenKit_Yip@...mail.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - sensirion,sht3x
> +      - sensirion,sts3x
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +addtionalProperties: false
> +
> +examples:
> +  - |
> +    sensor@4a {
> +      compatible = "sensirion,sht3x";
> +      reg = <0x4a>;
> +    };
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index ba2bfb547909..b2369d1fad68 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -331,6 +331,10 @@ properties:
>             - sensirion,sgp30
>               # Sensirion gas sensor with I2C interface
>             - sensirion,sgp40
> +            # Sensirion SHT3x-DIS humidity and temperature sensor
> +          - sensirion,sht3x
> +            # Sensirion STS3x humidity sensor
> +          - sensirion,sts3x
>               # Sensirion temperature & humidity sensor with I2C interface
>             - sensirion,sht4x
>               # Sensortek 3 axis accelerometer