linux-kernel - Re: (subset) [PATCH V2 0/4] Remove WARN_ON in save_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <168773507361.1389.9680109116196931036.b4-ty@rivosinc.com>
Date:   Sun, 25 Jun 2023 16:17:53 -0700
From:   Palmer Dabbelt <palmer@...osinc.com>
To:     Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>, aou@...s.berkeley.edu,
        chris@...kel.net, jcmvbkbc@...il.com, steven.price@....com,
        vincenzo.frascino@....com, leyfoon.tan@...rfivetech.com,
        mason.huo@...rfivetech.com, jeeheng.sia@...rfivetech.com,
        Conor Dooley <conor.dooley@...rochip.com>,
        ajones@...tanamicro.com, Song Shuai <songshuaishuai@...ylab.org>
Cc:     linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: (subset) [PATCH V2 0/4] Remove WARN_ON in save_processor_state


On Fri, 09 Jun 2023 15:50:45 +0800, Song Shuai wrote:
> During hibernation or restoration, freeze_secondary_cpus
> checks num_online_cpus via BUG_ON, and the subsequent
> save_processor_state also does the checking with WARN_ON.
> 
> In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
> is not defined, but the sole possible condition to disable
> CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
> We also don't have to check it in save_processor_state.
> 
> [...]

Applied, thanks!

[3/4] riscv: hibernate: remove WARN_ON in save_processor_state
      https://git.kernel.org/palmer/c/91afbaafd6b1

Best regards,
-- 
Palmer Dabbelt <palmer@...osinc.com>