linux-kernel - Re: (subset) [PATCH V2 0/4] Remove WARN_ON in save_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Jun 2023 11:28:56 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     Catalin Marinas <catalin.marinas@....com>
CC:     Will Deacon <will@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        aou@...s.berkeley.edu, chris@...kel.net, jcmvbkbc@...il.com,
        steven.price@....com, vincenzo.frascino@....com,
        leyfoon.tan@...rfivetech.com, mason.huo@...rfivetech.com,
        jeeheng.sia@...rfivetech.com,
        Conor Dooley <conor.dooley@...rochip.com>,
        ajones@...tanamicro.com, songshuaishuai@...ylab.org,
        linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject:     Re: (subset) [PATCH V2 0/4] Remove WARN_ON in save_processor_state

On Wed, 21 Jun 2023 08:51:43 PDT (-0700), Catalin Marinas wrote:
> On Fri, 09 Jun 2023 15:50:45 +0800, Song Shuai wrote:
>> During hibernation or restoration, freeze_secondary_cpus
>> checks num_online_cpus via BUG_ON, and the subsequent
>> save_processor_state also does the checking with WARN_ON.
>>
>> In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
>> is not defined, but the sole possible condition to disable
>> CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
>> We also don't have to check it in save_processor_state.
>>
>> [...]
>
> Applied to arm64 (for-next/misc), thanks!
>
> I couldn't tell whether this series would go in as a whole but given
> that the patches are independent, I picked up the arm64 one.
>
> [2/4] arm64: hibernate: remove WARN_ON in save_processor_state
>       https://git.kernel.org/arm64/c/615af0021a61

I was pretty much in the same spot until I saw this, so I'm picking the 
RISC-V bit and just ignoring the rest.  It's testing so it might take a bit to
land in linux-next, but seems pretty safe.