linux-kernel - Re: [PATCH] clk: imx: Drop inclusion of unused header <soc/imx/timer.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 25 Jun 2023 09:52:19 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        Peng Fan <peng.fan@....com>, Arnd Bergmann <arnd@...db.de>,
        Stephen Boyd <sboyd@...nel.org>,
        Fabio Estevam <festevam@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Linux Kernel Functional Testing <lkft@...aro.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        linux-arm-kernel@...ts.infradead.org,
        Abel Vesa <abelvesa@...nel.org>
Subject: Re: [PATCH] clk: imx: Drop inclusion of unused header
 <soc/imx/timer.h>

On Fri, Jun 23, 2023 at 09:19:19AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> After removing this header in the clocksource tree, the clk drivers no
> longer build:
> 
> drivers/clk/imx/clk-imx1.c:13:10: fatal error: 'soc/imx/timer.h' file not found
> drivers/clk/imx/clk-imx27.c:11:10: fatal error: 'soc/imx/timer.h' file not found
> 
> This patch was originally posted as part of a three-patch series, but only
> patches 1 and 3 got applied.
> 
> Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
> Fixes: 9e9d7570485d7 ("clocksource/drivers/imx-gpt: Fold <soc/imx/timer.h> into its only user")
> Link: https://lore.kernel.org/all/20230328100531.879485-2-u.kleine-koenig@pengutronix.de/
> Signed-off-by: "Uwe Kleine-König" <u.kleine-koenig@...gutronix.de>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

A bit strange that this patch has author=Arnd but still my S-o-b. Either
it's "my" patch (then I'd like to have author=Uwe), or it's Arnd's then
I'm not in the submission path and my S-o-b is misleading.

The commit log of this patch is better as it mentions the fact that only
a part of my series was applied and that the 0day bot was in the loop.
So I suggest to make my Signed-off-by line a Co-developed-by one (and
drop the quotes around my name).

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)