linux-kernel - Re: [PATCH] time: ntp: Remove unnecessary ‘-ENODEV’ values from err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <875y7a54jf.ffs@tglx>
Date:   Mon, 26 Jun 2023 22:53:24 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Li zeming <zeming@...china.com>, jstultz@...gle.com,
        sboyd@...nel.org
Cc:     linux-kernel@...r.kernel.org, Li zeming <zeming@...china.com>
Subject: Re: [PATCH] time: ntp: Remove unnecessary ‘-ENODEV’ values from err

On Wed, Jun 28 2023 at 02:25, Li zeming wrote:
> err is assigned first, so it does not need to initialize the
> assignment.

I don't know how you or the broken tool you rely upon came to that
conclusion.

There is clearly an error exit path which proves you wrong.

Please look at your changes and compile them before posting. There are
existing tools which do a better job than that.

Thanks,

        tglx