linux-kernel - Re: [RESEND v2] ufs: core: Add support for qTimestamp attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d034edbe84092fa4030fa2bf366d4b58c4b9405.camel@gmail.com>
Date:   Mon, 26 Jun 2023 14:36:56 +0200
From:   Bean Huo <huobean@...il.com>
To:     Arthur Simchaev <arthur.simchaev@....com>,
        martin.petersen@...cle.com
Cc:     avri.altman@....com, Avi.Shchislowski@....com, beanhuo@...ron.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        bvanassche@....org
Subject: Re: [RESEND v2] ufs: core: Add support for qTimestamp attribute

On Mon, 2023-06-26 at 13:33 +0300, Arthur Simchaev wrote:
>  
> +/**
> + * struct utp_upiu_query_v4_0 - upiu request buffer structure for
> + * query request >= UFS 4.0 spec.
> + * @opcode: command to perform B-0
> + * @idn: a value that indicates the particular type of data B-1
> + * @index: Index to further identify data B-2
> + * @selector: Index to further identify data B-3
> + * @osf4: spec field B-5
> + * @osf5: spec field B 6,7
> + * @osf6: spec field DW 8,9
> + * @osf7: spec field DW 10,11
> + */
> +struct utp_upiu_query_v4_0 {
> +       __u8 opcode;
> +       __u8 idn;
> +       __u8 index;
> +       __u8 selector;
> +       __u8 osf3;
> +       __u8 osf4;
> +       __be16 osf5;
> +       __be32 osf6;
> +       __be32 osf7;
> +       __be32 reserved;
> +};

Hi Arthur,
In fact, this structure should be a "Transaction Specific Fields" in
Query UPIU for all query functions. By comparing 3.1 and 4.0, you can
use current utp_upiu_query{}, because you only want to pass 64bit TS.
Or you can change utp_upiu_query() to make it more uniform to meet
various query functions.

Kind regards,
Bean