linux-kernel - RE: [RESEND v2] ufs: core: Add support for qTimestamp attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR04MB63275EC6110218B5F409AC59ED27A@BY5PR04MB6327.namprd04.prod.outlook.com>
Date:   Tue, 27 Jun 2023 11:22:36 +0000
From:   Arthur Simchaev <Arthur.Simchaev@....com>
To:     Bean Huo <huobean@...il.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     Avri Altman <Avri.Altman@....com>,
        Avi Shchislowski <Avi.Shchislowski@....com>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "bvanassche@....org" <bvanassche@....org>
Subject: RE: [RESEND v2] ufs: core: Add support for qTimestamp attribute

> 
> Hi Arthur,
> In fact, this structure should be a "Transaction Specific Fields" in
> Query UPIU for all query functions. By comparing 3.1 and 4.0, you can
> use current utp_upiu_query{}, because you only want to pass 64bit TS.
> Or you can change utp_upiu_query() to make it more uniform to meet
> various query functions.
>
Hi Bean

Actually, in the initial set of patches I changed utp_upiu_query , since the struct defined incorrectly
and I want to change it according to the spec, but according to Bart's comment,
the struct cannot be changed since the definition is in uapi . 
See the initial patch sets in the link below:

https://www.spinics.net/lists/linux-scsi/msg181985.html
https://www.spinics.net/lists/linux-scsi/msg182178.html
https://www.spinics.net/lists/linux-scsi/msg181987.html

Please let me know what you think.

Regards
Arthur