linux-kernel - Re: [PATCH] fs: iomap: Change the type of blocksize from 'int' to 'unsigned int' in iomap_file_buffered_write_punch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <df06d21b-9ae2-1e07-53f9-152eb2966bb9@nvidia.com>
Date:   Tue, 27 Jun 2023 22:50:25 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Lu Hongfei <luhongfei@...o.com>
CC:     "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>,
        "Darrick J. Wong" <djwong@...nel.org>,
        "opensource.kernel@...o.com" <opensource.kernel@...o.com>,
        Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH] fs: iomap: Change the type of blocksize from 'int' to
 'unsigned int' in iomap_file_buffered_write_punch_delalloc

On 6/27/23 03:03, Lu Hongfei wrote:
> The return value type of i_blocksize() is 'unsigned int', so the
> type of blocksize has been modified from 'int' to 'unsigned int'
> to ensure data type consistency.
>
> Signed-off-by: Lu Hongfei <luhongfei@...o.com>
> ---
>   fs/iomap/buffered-io.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index a4fa81af60d9..90ea9e09c1ae 100644
> --- a/fs/iomap/buffered-io.c
> +++ b/fs/iomap/buffered-io.c
> @@ -1076,7 +1076,7 @@ int iomap_file_buffered_write_punch_delalloc(struct inode *inode,
>   {
>   	loff_t			start_byte;
>   	loff_t			end_byte;
> -	int			blocksize = i_blocksize(inode);
> +	unsigned int	blocksize = i_blocksize(inode);
>   
>   	if (iomap->type != IOMAP_DELALLOC)
>   		return 0;

Indeed as per include/linux/fs.h:
719 static inline unsigned int i_blocksize(const struct inode *node)

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck