linux-kernel - Re: [PATCH 2/2] arm64: dts: add support for T7 based Amlogic AN400

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230627-pledge-recapture-7b17cc1c3c20@wendy>
Date:   Tue, 27 Jun 2023 08:25:58 +0100
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC:     Xianwei Zhao <xianwei.zhao@...ogic.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-amlogic@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH 2/2] arm64: dts: add support for T7 based Amlogic AN400

On Mon, Jun 26, 2023 at 05:41:05PM +0200, Krzysztof Kozlowski wrote:
> On 26/06/2023 11:52, Xianwei Zhao wrote:
> > +
> > +		apb4: bus@...00000 {
> > +			compatible = "simple-bus";
> > +			reg = <0x0 0xfe000000 0x0 0x480000>;
> > +			#address-cells = <2>;
> > +			#size-cells = <2>;
> > +			ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
> > +
> > +			uart_a: serial@...00 {
> > +				compatible = "amlogic,meson-s4-uart",
> > +					     "amlogic,meson-ao-uart";
> > +				reg = <0x0 0x78000 0x0 0x18>;
> > +				interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
> > +				status = "disabled";
> 
> Please, don't put status in the middle of properties...

The serial entry is also missing the soc specific compatible (and
removal of the always-on uart) that was discussed in Lucas Tanure's
series.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)