linux-kernel - Re: [PATCH v3] block: add check that partition length needs to be aligned with block size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230628073214.GA25314@lst.de>
Date:   Wed, 28 Jun 2023 09:32:14 +0200
From:   Christoph Hellwig <hch@....de>
To:     Min Li <min15.li@...sung.com>
Cc:     axboe@...nel.dk, willy@...radead.org, hch@....de,
        dlemoal@...nel.org, gregkh@...uxfoundation.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...nel.org
Subject: Re: [PATCH v3] block: add check that partition length needs to be
 aligned with block size

On Wed, Jun 28, 2023 at 01:09:41PM +0000, Min Li wrote:
> +	long long blksz = bdev_logical_block_size(bdev), start, length;

long long for the blocksize is a bit weird here, as the value is
an unsigned int.

Also while pre-existing the long long for start/length looks weird,
do we need to check for negative values somewhere?

Also don't forget the Cc stable that Greg requested.