linux-kernel - Re: [PATCH] wifi: plfxlc: Fix possible data races in rx_urb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e7faf02-2724-9d27-364e-eedcd5fc5567@yandex.ru>
Date:   Wed, 28 Jun 2023 07:54:22 +0300
From:   Dmitry Antipov <dmantipov@...dex.ru>
To:     Tuo Li <islituo@...il.com>, srini.raju@...elifi.com,
        kvalo@...nel.org
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        baijiaju1990@...look.com, BassCheck <bass@...a.edu.cn>
Subject: Re: [PATCH] wifi: plfxlc: Fix possible data races in
 rx_urb_complete()

On 6/28/23 05:21, Tuo Li wrote:

>   		if (tx->submitted_urbs++ < PURELIFI_URB_RETRY_MAX) {
>   			dev_dbg(plfxlc_urb_dev(urb), "urb %p resubmit %d", urb,
>   				tx->submitted_urbs++);

BTW, doing 'tx->submitted_urbs++' inside a debugging statement is most likely
a bad idea.

Dmitry