linux-kernel - Re: [PATCH v3 3/4] clk: sunxi-ng: Convert early providers to platform drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yw1xa5wj3kvn.fsf@mansr.com>
Date:   Wed, 28 Jun 2023 12:07:56 +0100
From:   Måns Rullgård <mans@...sr.com>
To:     Maxime Ripard <mripard@...nel.org>
Cc:     Samuel Holland <samuel@...lland.org>, Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        linux-sunxi@...ts.linux.dev,
        Michael Turquette <mturquette@...libre.com>,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Stephen Boyd <sboyd@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/4] clk: sunxi-ng: Convert early providers to
 platform drivers

Maxime Ripard <mripard@...nel.org> writes:

> On Mon, Jun 26, 2023 at 01:21:33PM +0100, Måns Rullgård wrote:
>> Samuel Holland <samuel@...lland.org> writes:
>> 
>> > The PRCM CCU drivers depend on clocks provided by other CCU drivers. For
>> > example, the sun8i-r-ccu driver uses the "pll-periph" clock provided by
>> > the SoC's main CCU.
>> >
>> > However, sun8i-r-ccu is an early OF clock provider, and many of the
>> > main CCUs (e.g. sun50i-a64-ccu) use platform drivers. This means that
>> > the consumer clocks will be orphaned until the supplier driver is bound.
>> > This can be avoided by converting the remaining CCUs to use platform
>> > drivers. Then fw_devlink will ensure the drivers are bound in the
>> > optimal order.
>> >
>> > The sun5i CCU is the only one which actually needs to be an early clock
>> > provider, because it provides the clock for the system timer. That one
>> > is left alone.
>> >
>> > Signed-off-by: Samuel Holland <samuel@...lland.org>
>> > ---
>> >
>> > (no changes since v1)
>> >
>> >  drivers/clk/sunxi-ng/Kconfig             | 20 ++++----
>> >  drivers/clk/sunxi-ng/ccu-sun4i-a10.c     | 58 +++++++++++++--------
>> >  drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c   | 56 ++++++++++++--------
>> >  drivers/clk/sunxi-ng/ccu-sun50i-h616.c   | 33 ++++++++----
>> >  drivers/clk/sunxi-ng/ccu-sun6i-a31.c     | 40 +++++++++++----
>> >  drivers/clk/sunxi-ng/ccu-sun8i-a23.c     | 35 +++++++++----
>> >  drivers/clk/sunxi-ng/ccu-sun8i-a33.c     | 40 +++++++++++----
>> >  drivers/clk/sunxi-ng/ccu-sun8i-h3.c      | 62 ++++++++++++++--------
>> >  drivers/clk/sunxi-ng/ccu-sun8i-r.c       | 65 ++++++++++++++----------
>> >  drivers/clk/sunxi-ng/ccu-sun8i-v3s.c     | 57 +++++++++++++--------
>> >  drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c | 38 ++++++++++----
>> >  11 files changed, 332 insertions(+), 172 deletions(-)
>> 
>> This broke the hstimer clocksource on A20 since it requires a clock
>> provided by the sun4i ccu driver.
>
> The A10 is probably broken by this, but the A20 should be able to use
> the arch timers just like all the other Cortex-A7-based SoCs.
>
> Do you have a dmesg log that could help debug why it's not working?

The A20 works as such since, as you say, it has other clocksources.
However, the hstimer has become unusable.  If anyone was using, for
whatever reason, it won't be working for them now.

Before this change, the kernel log used include this line:

clocksource: hstimer: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 6370868154 ns

Now there is only a cryptic "Can't get timer clock" in its place.

As it is now, the hstimer driver is nothing but a waste of space.
I figure it ought to be fixed one way or another.

-- 
Måns Rullgård