linux-kernel - Re: [PATCH v2 0/3] fs/ecryptfs: Replace kmap{,_atomic}() with kmap_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23780760.ouqheUzb2q@suse>
Date:   Wed, 28 Jun 2023 15:50:30 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Tyler Hicks <code@...icks.com>,
        Christian Brauner <brauner@...nel.org>,
        Dave Chinner <dchinner@...hat.com>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Al Viro <viro@...iv.linux.org.uk>, ecryptfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] fs/ecryptfs: Replace kmap{,_atomic}() with
 kmap_local_page()

On mercoledì 26 aprile 2023 19:22:20 CEST Fabio M. De Francesco wrote:
> kmap() and kmap_atomic() have been deprecated in favor of
> kmap_local_page().
> 
> Therefore, replace kmap() and kmap_atomic() with kmap_local_page().

After two months from submission, I haven't received any comments on this 
short series yet, except for a "Reviewed by" tag from Ira on patch 1/3 only.

I would appreciate any comments/reviews/acks and would especially like to know 
if anything is preventing these patches from being applied.

Thank you all in advance,

Fabio

> Tested in a QEMU/KVM x86_32 VM, 6GB RAM, booting a kernel with
> HIGHMEM64GB enabled.
> 
> v1->v2: Patches 1/3 and 2/3 were not grouped in a series. Patch 3/3 is
> new. Therefore, currently one series groups all conversions needed if
> fs/ecryptfs. The subject of 2/3 changed to differentiate between it and
> 3/3. Furthermore, the commit messages of 1/3 and 2/3 have been largely
> reworked.
> 
> Fabio M. De Francesco (3):
>   fs/ecryptfs: Replace kmap() with kmap_local_page()
>   fs/ecryptfs: Use kmap_local_page() in ecryptfs_write()
>   fs/ecryptfs: Use kmap_local_page() in copy_up_encrypted_with_header()
> 
>  fs/ecryptfs/crypto.c     |  8 ++++----
>  fs/ecryptfs/mmap.c       |  4 ++--
>  fs/ecryptfs/read_write.c | 12 ++++++------
>  3 files changed, 12 insertions(+), 12 deletions(-)
> 
> --
> 2.40.0