linux-kernel - Re: [PATCH v2 0/3] fs/ecryptfs: Replace kmap{,_atomic}() with kmap_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230630023107.GA1088@sol.localdomain>
Date:   Thu, 29 Jun 2023 19:31:07 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Tyler Hicks <code@...icks.com>,
        Christian Brauner <brauner@...nel.org>,
        Dave Chinner <dchinner@...hat.com>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Al Viro <viro@...iv.linux.org.uk>, ecryptfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] fs/ecryptfs: Replace kmap{,_atomic}() with
 kmap_local_page()

On Wed, Jun 28, 2023 at 03:50:30PM +0200, Fabio M. De Francesco wrote:
> On mercoledì 26 aprile 2023 19:22:20 CEST Fabio M. De Francesco wrote:
> > kmap() and kmap_atomic() have been deprecated in favor of
> > kmap_local_page().
> > 
> > Therefore, replace kmap() and kmap_atomic() with kmap_local_page().
> 
> After two months from submission, I haven't received any comments on this 
> short series yet, except for a "Reviewed by" tag from Ira on patch 1/3 only.
> 
> I would appreciate any comments/reviews/acks and would especially like to know 
> if anything is preventing these patches from being applied.
> 

eCryptfs is in "Odd Fixes" status.  See the thread
https://lore.kernel.org/ecryptfs/ZB4nYykRg6UwZ0cj@sequoia/T/#u

I would suggest that if Tyler is not responding, that Christian or Al take these
patches through the VFS tree instead.

FWIW, I took a quick look at these three patches, and all look correct.  I'm not
sure I want to give a formal R-b, as I don't want people to start bothering me
about eCryptfs stuff because they saw my name on it :-)

- Eric