[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZJ3kG7CSWSGw1Ql2@corigine.com>
Date: Thu, 29 Jun 2023 22:05:47 +0200
From: Simon Horman <simon.horman@...igine.com>
To: You Kangren <youkangren@...o.com>
Cc: Kalle Valo <kvalo@...nel.org>, Dongliang Mu <dzm91@...t.edu.cn>,
Christophe JAILLET <christophe.jaillet@...adoo.fr>,
"open list:RAYLINK/WEBGEAR 802.11 WIRELESS LAN DRIVER"
<linux-wireless@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>,
opensource.kernel@...o.com
Subject: Re: [PATCH v3] wifi: ray_cs: Replace the ternary conditional
operator with min()
On Tue, Jun 27, 2023 at 12:31:48PM +0800, You Kangren wrote:
> Replace the ternary conditional operator with min_t() to simplify the code
>
> Signed-off-by: You Kangren <youkangren@...o.com>
> ---
> drivers/net/wireless/legacy/ray_cs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/legacy/ray_cs.c b/drivers/net/wireless/legacy/ray_cs.c
> index 8ace797ce951..25edbc655738 100644
> --- a/drivers/net/wireless/legacy/ray_cs.c
> +++ b/drivers/net/wireless/legacy/ray_cs.c
> @@ -2086,8 +2086,7 @@ static void ray_rx(struct net_device *dev, ray_dev_t *local,
> rx_data(dev, prcs, pkt_addr, rx_len);
>
> copy_from_rx_buff(local, (UCHAR *) &local->last_bcn, pkt_addr,
> - rx_len < sizeof(struct beacon_rx) ?
> - rx_len : sizeof(struct beacon_rx));
> + min_t(size_t, rx_len, sizeof(struct beacon_rx));
Hi You Kangen,
unfortunately this patch doesn't seem to compile.
Powered by blists - more mailing lists