linux-kernel - Re: [PATCH] HID: steelseries: Add support for Arctis 1 XBox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Jun 2023 13:09:38 -0700
From:   Rahul Rameshbabu <rrameshbabu@...dia.com>
To:     Bastien Nocera <hadess@...ess.net>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>
Subject: Re: [PATCH] HID: steelseries: Add support for Arctis 1 XBox

On Thu, 29 Jun, 2023 22:03:05 +0200 Bastien Nocera <hadess@...ess.net> wrote:
> On Thu, 2023-06-29 at 11:50 -0700, Rahul Rameshbabu wrote:
>> On Thu, 29 Jun, 2023 19:20:27 +0200 Bastien Nocera
>> <hadess@...ess.net> wrote:
>> > +static const struct hid_device_id steelseries_devices[] = {
>> > +       { HID_USB_DEVICE(USB_VENDOR_ID_STEELSERIES,
>> > USB_DEVICE_ID_STEELSERIES_SRWS1),
>> > +         .driver_data = STEELSERIES_SRWS1 },
>> > +
>> > +       { /* SteelSeries Arctis 1 Wireless for XBox */
>> > +         HID_USB_DEVICE(USB_VENDOR_ID_STEELSERIES, 0x12b6),
>> 
>> Shouldn't the USB device id be added to drivers/hid/hid-ids.h?
>
> No, the hid-ids.h is only used if 2 files in the hid directory need to
> reference the same device.
>
> Since changes to the way hid drivers are loaded, there's no need to
> blocklist the devices in the core to handle them in a driver, so
> there's no need to reference the device in another place than the
> driver itself, so no need to add it to hid-ids.h

Makes sense with the fact that the device id is only needed in this
source file. For example, you don't need to recompile the steelcase
driver module when introduce some other unrelated device. Thanks for the
clarification.

-- Rahul Rameshbabu